[SunkenInTime]

page_screenshots_test "only Stop ends a capture" failed on and off on Windows: in CI's windows-test lane and locally, including twice in a row on main on Oct 20. It came up again on #399, whose extra work per frame made it fail more often (locally 2 out of 3 runs on that stack, 3 out of 3 passes on main).

Cause: the "Screenshots cancelled." toast is shown while the test waits in real time (runAsync) for the dialog to close, so the toast's 3-second auto-close timer runs on real time. That breaks the test in two ways:

• The toast was gone before the check. Timed runs put the toast at about 3.0 s and the final check at about 5.1 s, under a second of margin, and a slow runner closed it first.
• Once that was fixed, CI showed the second way: the toast closed itself after the test ended, on a torn-down tree ("AnimationController.dispose() called more than once"). Dismissing it at the end of the test was too late, because its real-time removal could already be under way.

Fix: the test takes the toast away the moment it sees it, while waiting for the dialog to close. That stops its real-time timer, so its removal runs on the test's clock and finishes inside the test. The app is unchanged.

Checked:

• The test passes 5 out of 5 on main and 5 out of 5 on the Select items on the canvas with a box or a click #399–Copy and paste items between strategies on the same map #401 stack, where it failed 2 out of 3 before.
• The whole file passes (12 tests).
• CI's Windows lane is what showed the second failure, so it is the real check.

ci: test desktop

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: da19b995-cf6f-49c9-89a9-c088468c6d6a

Commits

Reviewing files that changed from the base of the PR and between bb7ccaf and 85a7841.

Files selected for processing: 1

• test/page_screenshots_test.dart

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The screenshot cancellation test now records whether the “Screenshots cancelled.” toast appears while the save dialog closes. It checks whether the toast appeared during the wait instead of requiring it to remain visible afterward.

Changes: Screenshot cancellation test

Layer / File(s)	Summary
Observe cancellation toast during close test/page_screenshots_test.dart	The test pumps real and test time while the dialog closes, records whether the cancellation toast appears, and asserts that it was observed during the wait.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

• SunkenInTime/icarus#399: Reports the same screenshot test failure; this PR changes its toast timing check.
• SunkenInTime/icarus#395: Reports a failure in the same screenshot test; this PR changes its timing check.

Merge Risk: Minimal · up to 85a78

The test-only timing change has no identified merge-blocking risk.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title describes the main change: checking for the cancelled-screenshots toast while it appears. The wording is slightly awkward but remains clear and relevant.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}