Skip to content

feat(linux-browse): switch a table tab between Data and Structure from its bottom bar - #4108

Merged
datlechin merged 17 commits into
TableProApp:mainfrom
sedax90:feat/linux-browse-structure-switch
Nov 9, 2026
Merged

datlechin merged 17 commits into
TableProApp:mainfrom
sedax90:feat/linux-browse-structure-switch

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Switch a table tab between Data and Structure from its bottom bar. The native switch supports keyboard navigation and screen readers.
  • Keep each view's edits and controls together. Save and Refresh follow the selected view. Compact tabs keep commands in More.
  • Close checks both sets of changes and warns about uncertain saves. A schema rename keeps the tab and pending rows.
  • Keep row ranges consistent when page and count queries return different snapshots.

Screenshots

Light Dark
Before Before, light Before, dark
After: Data After, light After, dark
After: Structure Structure, light Structure, dark

Test plan

  • the_bottom_bar_switches_between_data_and_structure now checks native tab roles, keyboard activation, lazy loading and retained Data state.
  • Save and close tests cover both trackers, unknown outcomes, serial writes and rename. Grid and count tests cover renamed SQL copies and stale totals.
  • New regressions cover refresh/read races, commands in compact tabs, wide restoration and the 360px window floor with Structure enabled.
  • Fast checks and Flatpak passed on the current head. Fast checks include formatting, Clippy, eight Meson test targets and seven Secret Service tests.

@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
…ucture-switch

# Conflicts:
#	linux/crates/app/src/ui/browse_tab/tests/mod.rs
#	linux/crates/app/src/ui/workspace/tab_factory.rs
#	linux/crates/app/src/ui/workspace/tests/close_tab.rs
#	linux/crates/app/src/ui/workspace/workspace_tabs.rs
#	linux/data/resources/ui/browse-tab.ui
…ucture-switch

# Conflicts:
#	linux/crates/app/src/ui/browse_tab/data_handlers.rs
#	linux/crates/app/src/ui/browse_tab/data_input.rs
#	linux/crates/app/src/ui/browse_tab/tests/mod.rs
TableProApp#4113 and TableProApp#4134 landed one after the other, and main stopped compiling at this call.
@datlechin
datlechin merged commit 092f070 into TableProApp:main Nov 9, 2026
29 checks passed
datlechin added a commit to sedax90/TablePro that referenced this pull request Nov 9, 2026
TableProApp#4108's rename handler on main still read connection_id, which this branch replaced with state_key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants