Repository navigation
feat(linux-browse): switch a table tab between Data and Structure from its bottom bar - #4108
Merged
datlechin merged 17 commits intoNov 9, 2026
Merged
Conversation
This was referenced Nov 8, 2026
datlechin
added this pull request to the merge queue
Nov 9, 2026
…ucture-switch # Conflicts: # linux/crates/app/src/ui/browse_tab/tests/mod.rs # linux/crates/app/src/ui/workspace/tab_factory.rs # linux/crates/app/src/ui/workspace/tests/close_tab.rs # linux/crates/app/src/ui/workspace/workspace_tabs.rs # linux/data/resources/ui/browse-tab.ui
…ate no longer meets
…ucture-switch # Conflicts: # linux/crates/app/src/ui/browse_tab/data_handlers.rs # linux/crates/app/src/ui/browse_tab/data_input.rs # linux/crates/app/src/ui/browse_tab/tests/mod.rs
TableProApp#4113 and TableProApp#4134 landed one after the other, and main stopped compiling at this call.
datlechin
added a commit
to sedax90/TablePro
that referenced
this pull request
Nov 9, 2026
TableProApp#4108's rename handler on main still read connection_id, which this branch replaced with state_key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Test plan
the_bottom_bar_switches_between_data_and_structurenow checks native tab roles, keyboard activation, lazy loading and retained Data state.