Repository navigation
fix(macos): stop the data loss, wrong writes and gate bypasses the code audit found - #4174
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
November 10, 2026 10:56
datlechin
disabled auto-merge
November 10, 2026 10:56
# Conflicts: # apple/TablePro/Core/MCP/MCPTokenStore.swift # apple/TableProTests/Core/MCP/MCPTokenStoreTests.swift
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes for 55 defects from a code audit of the macOS app and its plugins. Not reviewed by Codex yet (out of quota until Nov 14): do not merge before that review.
Editing and execution
Sessions and structure
Drivers
SET ... KEEPTTL,RENAMENXandSET NXfor rename and new string keys.MUSTAPPLYis accepted only around those two and graded by the wrapped command.mvis graded destructive.Import and export
AI, MCP, storage
connections.jsontag reads as modified. Secrets of a Local only connection are written device-only.Tests that pinned behavior this PR changes on purpose
ScopedDriverRoutingTests,SessionLanesTests: a foreign-database statement routes to a session connection.CrossEngineValueCoercerTests.aPostgresArrayBecomesJson: atext[]becomes JSON strings.RedisStatementGeneratorTests,RedisBinaryValueTests,RedisCommandParserTests:SETupdates carryKEEPTTL.SyncCategoryRefetchTests.turningACategoryOnRefetches: pull count.KeywordUppercaseHelperTests: signature only.Needs the maintainer
Test plan
verify.sh build,plugins,abi,lint,l10n: PASS.verify.sh test(Unit plan): 29342 executed, 29342 passed.verify.sh package TableProCore: 76 passed for the new DuckDB, document path and operator suites.verify.sh ios MongoDBStringFieldWriteTests: INCONCLUSIVE, no simulator on this Mac.apple/scripts/probes/check-parquet-export-values.shandcheck-duckdb-streaming-results.shpass against the bundled libduckdb.