Repository navigation
perf(macos): append the execution log in place, skip unchanged tab saves, read agent CLI pipes apart and release closed agent sessions - #4212
Merged
Conversation
…ves, read CLI pipes per pipe and release closed agent sessions
datlechin
enabled auto-merge (squash)
November 11, 2026 23:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance audit 2026-11-11, lane L1.
ExecutionAudit.json, same array the previous stable reads and rewrites, so the chain stays one chain across an upgrade and a downgrade.ExecutionAudit.damaged-<time>.json. Before, an unreadable log was overwritten by a new chain.FileHandle.bytes, whose reads share one serial queue. The quiet stderr read blocked stdout, so text arrived only at exit and a reply past 64 KB hung. Copilot's LSP reader parked the same queue. Both now read each pipe withPipeReader(readabilityHandler).AgentCLIProcess.runread its pipe only at exit and also hung past 64 KB..gzdecompression: a 393 MB file +397 MB to +2 MB..gzdecompresses no longer imports the first file.Needs the maintainer
SQLFileParser). The wave 5 editor lane is rewriting that file and has not merged, so that part follows it.Test plan
ExecutionAuditLogTests: an earlier build's log goes on, the file decodes as the array after appends, a tail past 64 KB, torn tail repaired, unreadable log set aside byte for byte, held record linked at write time, same-size replacement read again.TabDiskUnchangedSaveTests: an unchanged save keeps the same file (inode), a removed or unreadable file is written again, a changed sidecar is rewritten.AgentCLIProcessTests: 30,000 lines beside a silent stderr (hangs on main), a line arrives before the child exits,runpast 64 KB.LSPTransportReadTests: server messages arrive while anAsyncBytesread elsewhere waits (hangs on main).AIChatSessionReleaseTests,AIChatStorageSummaryTests,AgentSessionRegistryTests,AIChatTableMentionsTests.AgentSessionRegistryTests"Stopping a session keeps it and its transcript" now checks the transcript is on disk and memory is empty.ImportStatementCountTests: a cancelled count stops before the end of the file.