Repository navigation
fix(drivers): keep Oracle values typed, fix Teradata ANSI transactions, complete SQL Server, Oracle and PostgreSQL DDL, and bound driver streams - #4223
Merged
Conversation
…s, complete SQL Server, Oracle and PostgreSQL DDL, bound driver streams
… the tests to the output
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit 2026-11-12, lane sql-drivers.
00123stays text, a date goes through a fixed mask and NVARCHAR2 text goes asUNISTR. PluginKit carries the types inPluginStatementContext.parameterTypeNames; Oracle implements thecontext:overloads. An untyped value keeps the PluginKit rule, with its padding-zero guard.SEARCH_CONDITION_VC), so the foreign keys the export adds afterwards restore. Indexes those constraints own are left out of the index phase. A NOVALIDATE constraint goes in disabled and is enabledNOVALIDATEafter the rows.IDENTITY(seed, increment), and COLLATE where it differs from the database default. A disabled or untrusted check is switched off before the rows, and an untrusted one turned back onWITH NOCHECKafter them.COLLATION_NAME, and ALTER COLUMN restates the collation for a character type.HELP SESSION, thenDBC.SessionInfoV). ANSI sessions send no BT/ET, commit withCOMMIT WORKand roll back withROLLBACK WORK; the rollback's 3513/3514 answer counts as success. The driver reports its transaction state, so a save never commits or rolls back the editor's uncommitted work. Run All of a batch with DDL runs unwrapped (TransactionEngineFamily.teradata), and a statement failure that leaves a transaction open says so instead of "stays applied".PluginRowStream.makeBounded,deliverBlocking,deliver). Object Copy, Table Transfer and Compare lift the session query timeout around their reads, as an export does, since the source statement now lasts as long as the copy. A MySQL streaming session raisesnet_write_timeoutto 600.CONSTRAINT_TYPE = 'CHECK'.PARTITION OFlist, and its own indexes and comments after the partitions. A foreign table partition is written as a comment with its server and options, never created.MSSQLCreateTableStatementTests.bracketInKeyNamesIsDoubled,MSSQLSchemaQueriesTests.testAllColumnsQueryCarriesTheTableNameAfterTheParsedColumns,PostgreSQLTableDDLTests.partitionTreeOrder,ImportDataSinkAdapterBitColumnTests.anEngineThatReadsBitsAsDigitsIsNotAsked(nowanEngineThatReadsBitsAsDigitsGetsNoCast).Needs the maintainer
Known limits
net_write_timeoutto 600, so a reader stalled for 10 minutes still ends the read.Test plan
verify.sh: build, AllPlugins, the ABI check, lint, the Unit suites for the changed types,TableProCore(PluginKit, MSSQL, Teradata, DuckDB, PostgreSQL cores),TableProOracle.PluginRowStreamDeliveryTests,BulkReadTimeoutTests,SQLStatementGeneratorParameterTypeTests,ImportDataSinkAdapterParameterTypeTests,OracleTableConstraintTests,MSSQLAlterColumnStatementTests,TeradataTransactionTests,AutocommitOnlyStatementTeradataTests, and cases inPostgreSQLTableDDLTests,MSSQLCreateTableStatementTests,MySQLCheckConstraintsTests,ObjectCopyRowCopierTests,TransactionEngineFamilyTests,BatchTransactionPolicyTests.