Repository navigation
feat(windows): save queries in folders, pin history runs, import CSV into a table, duplicate and export connections - #4288
Merged
Conversation
…into a table, duplicate and export connections
…hat the import writes
…annot multiply the file's memory
… a replaced saved query's place
… tab's query block
…he file to the core's tests
…age-import # Conflicts: # windows/src/TablePro.Interop/Generated/tablepro_ffi.cs
datlechin
enabled auto-merge (squash)
November 15, 2026 07:14
…age-import # Conflicts: # core/crates/ffi/src/lib.rs # core/docs/decisions/README.md # windows/AGENTS.md # windows/src/TablePro.App/Strings/en-US/Resources.resw # windows/src/TablePro.App/Views/WorkspaceView.xaml.cs # windows/src/TablePro.Interop/Generated/tablepro_ffi.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SavedQueryStore(queries, folders, keywords, order, edit by id,delete_for_connection) andFavouriteStore(tables, databases with an environment) over the history's database;QueryHistoryStoregainsset_pinnedandexport.DatabaseSession::open_csv_importgives aCsvImportthat previews a file, suggests a mapping, plans it (a field a column cannot read comes back with its line) and runs the plan it named once, under the row save's Safe Mode gate, reporting the failed lines. Rows are padded one at a time (read_csv_records, new), so one wide record cannot multiply the file's memory.ConnectionLibrary::duplicatecopies a connection with every secret right after the original;export_filewrites the connections file without secrets.windows/AGENTS.mdupdated.DraftStore(Windows keeps tab text in session.json),PastedRows(W-28 waits on C-10), keyword expansion (needs completion, W-31), favourite tables and databases in the UI (no W item), history retention (feat(windows): production cue, database switchers, find and replace, sql files, redis key tab, cassandra paging and display settings #4285). The Linux import still pads every row throughread_csv; moving it toread_csv_recordsis a Linux change.Test plan
cargo test -p tablepro-ffi:tests/saved_queries.rs,tests/csv_import.rs,tests/library_copies.rs(fail on main, where the API does not exist);tablepro-coreandtablepro-storageunit tests forread_csv_recordsandset_query.TablePro.Interop.Tests:SavedQueryTests,CsvImportTests,ConnectionCopyTestson real SQLite files and stores.TablePro.App.Model.Tests: saved query tree and names, CSV import form, copy names, history pins.Screenshots
New surfaces, so no before shots.
Saved queries in a folder:
Save query, and a pinned history run:
CSV import, and the rows it added:
Duplicate opens the form on the copy: