Repository navigation
fix(windows): stop two UI tests reading a rebuilt row and a clickable point once - #4297
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AQueryIsSavedIntoAFolderAndARunIsPinned: the move rebuilds the saved queries tree, and the test read the folder row it found just before. WinUI reports a removed tree row'sExpandCollapseStateas not supported. Reads of rows in lists the app rebuilds now go throughAppSession.Holds, which reads the new row on the next try: the saved query folder and history waits, and the tag waits on the Connections page.ATableKeepsItsPageSizeAndGoesToAPageInsideItsCount: a live button's clickable point can fail to read for one moment after a page change, on Arm64 and x64, with or without the flyout. FlaUI's click throwsNoClickablePointExceptionon that first failed read.AppSession.PointOfreads the point again for up to 5 seconds;Click,RightClick,DoubleClick,DragandCheckuse it, and the tests that called FlaUI's click directly now go throughAppSession.windows/docs/decisions/0004-app-shell.md(What the runner showed) records both facts with run ids;verification-windows.mdpoints to them.Test plan
windows-11-armthe unchanged saved query test failed 7 of 12 rounds (run 43737243526).PropertyNotSupportedException12 times in 12, and the new check passed 12 times in 12; both tests in both themes passed 30 rounds across five Arm64 jobs and 6 on x64.dotnet build tests/TablePro.App.UITestson macOS; the UI tests run in this PR's Windows jobs.