Skip to content

fix(windows): stop two UI tests reading a rebuilt row and a clickable point once - #4297

Merged
datlechin merged 3 commits into
mainfrom
fix/windows-arm64-ui-flakes
Nov 15, 2026
Merged

datlechin merged 3 commits into
mainfrom
fix/windows-arm64-ui-flakes

Conversation

@datlechin

Copy link
Copy Markdown
Member

Summary

  • AQueryIsSavedIntoAFolderAndARunIsPinned: the move rebuilds the saved queries tree, and the test read the folder row it found just before. WinUI reports a removed tree row's ExpandCollapseState as not supported. Reads of rows in lists the app rebuilds now go through AppSession.Holds, which reads the new row on the next try: the saved query folder and history waits, and the tag waits on the Connections page.
  • ATableKeepsItsPageSizeAndGoesToAPageInsideItsCount: a live button's clickable point can fail to read for one moment after a page change, on Arm64 and x64, with or without the flyout. FlaUI's click throws NoClickablePointException on that first failed read. AppSession.PointOf reads the point again for up to 5 seconds; Click, RightClick, DoubleClick, Drag and Check use it, and the tests that called FlaUI's click directly now go through AppSession.
  • Neither is an app defect: the tree rebuild is the pane's design, as on the Connections page, and the button works for the pointer throughout.
  • The tag wait in the daily use test now asserts its result.
  • windows/docs/decisions/0004-app-shell.md (What the runner showed) records both facts with run ids; verification-windows.md points to them.

Test plan

  • Temporary branch runs, deleted after: on windows-11-arm the unchanged saved query test failed 7 of 12 rounds (run 43737243526).
  • Run 43742489353, with the change: the old check fed the row found before the move threw PropertyNotSupportedException 12 times in 12, and the new check passed 12 times in 12; both tests in both themes passed 30 rounds across five Arm64 jobs and 6 on x64.
  • Clickable point sampling in the same runs: 22 of 22,231 reads over 216 page changes failed on Arm64, 4 of 5,762 over 48 on x64, each between two reads that passed.
  • dotnet build tests/TablePro.App.UITests on macOS; the UI tests run in this PR's Windows jobs.

@datlechin
datlechin merged commit b474a39 into main Nov 15, 2026
13 checks passed
@datlechin
datlechin deleted the fix/windows-arm64-ui-flakes branch November 17, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant