Skip to content

test(cassandra): hold the refused port in the relay's failed-open test - #4298

Merged
datlechin merged 2 commits into
mainfrom
fix/cassandra-relay-failure-order
Nov 15, 2026
Merged

datlechin merged 2 commits into
mainfrom
fix/cassandra-relay-failure-order

Conversation

@datlechin

@datlechin datlechin commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Summary

  • relay::tests::a_failed_open_is_kept_for_the_connect_to_report bound 127.0.0.1:0, dropped the listener, then dialled that port expecting a refused connect.
  • On windows-2025 a relay test running at the same time can bind that port. The relay's open then connects to the other test's relay instead of being refused, and the stream closes when that test ends: EOF with no failure stored (job 132850861520), or a silent stream until the 15 s timeout (job 132735315897).
  • The test now holds the port with a TcpSocket that is bound and never listens. Linux and Windows refuse every connect to it, and no other bind can take it.
  • The relay is unchanged: the Cassandra, MySQL and MongoDB relays all store the open failure before the client stream closes.

Test plan

  • windows-2025, the whole cassandra lib suite in a loop (runs 43749549367, 43751468848, 43755130337): main's test failed 11 of 850 runs, the held port 0 of 450.
  • The 8 failures in 43755130337, which logged the relay's steps, all show the dialled port bound by another test's relay, which accepted the open and closed with that test.
  • Linux (dev image): the whole lib suite 300 times and the test alone 300 times, no failure.
  • verify.sh --platform windows core tablepro-driver-cassandra on macOS: PASS. The relay tests run on Linux and Windows only.

@datlechin
datlechin merged commit 989d8cd into main Nov 15, 2026
46 of 47 checks passed
@datlechin
datlechin deleted the fix/cassandra-relay-failure-order branch November 17, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant