Repository navigation
test(cassandra): hold the refused port in the relay's failed-open test - #4298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
relay::tests::a_failed_open_is_kept_for_the_connect_to_reportbound 127.0.0.1:0, dropped the listener, then dialled that port expecting a refused connect.TcpSocketthat is bound and never listens. Linux and Windows refuse every connect to it, and no other bind can take it.Test plan
verify.sh --platform windows core tablepro-driver-cassandraon macOS: PASS. The relay tests run on Linux and Windows only.