Repository navigation
Hand a moved workspace's signed-in member to v2 - #2356
Merged
Merged
Conversation
RhysSullivan
added this pull request to stack #2358
October 23, 2026 20:43
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | e982d35 | Oct 23 2026, 08:45 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | e982d35 | Commit Preview URL Branch Preview URL |
Oct 23 2026, 08:44 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard redirects a signed-in member of a workspace that has moved to v2. They then had to sign in again on v2, because the
wos-sessioncookie never reaches v2's host.With
V2_SESSION_HANDOFF_SECRETset, the doc gate now sends them to<v2 app origin>/api/v1-handoff?token=<t>instead of/org/<slug>. The token is minted only after the gate has verified the WorkOS session andisMemberhas confirmed the membership. v2 checks it and starts its own session. v2 offers no WorkOS sign-in.v1hnd.<payload>.<sig>: base64url JSON{v: 1, aud: "v2-session-handoff", user, organization, slug, iat, exp, jti},exp60 s afteriat, randomjti. The signature is base64url HMAC-SHA256 overv1hnd.<payload>.V2_MCP_FORWARD_SECRET.v2 side: UsefulSoftwareCo/executor-next#3358 (tests: #3359). Tests for this PR: #2357.
New secret:
V2_SESSION_HANDOFF_SECRET(Worker secret), the same value as v2'sV1_SESSION_HANDOFF_SECRET.One-time production setup (not done here): generate one random secret of at least 32 characters (
openssl rand -hex 32). Set it withwrangler secret put V2_SESSION_HANDOFF_SECREThere, and asV1_SESSION_HANDOFF_SECRETon v2. Deploy v2's side first, or both together: until v2 has the route and the secret, a handoff falls back to v2's sign-in page.