[ALL] Fix grenade prediction metadata and impact time initialization - #2030
Open
speedvoltage wants to merge 1 commit into
Open
[ALL] Fix grenade prediction metadata and impact time initialization#2030speedvoltage wants to merge 1 commit into
speedvoltage wants to merge 1 commit into
Conversation
Correct the grenade radius prediction type and use tolerances matching its wire quantization. Network, save, and initialize the next-impact attack time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Base grenades use incorrect prediction metadata for their damage radius and do not track their next impact attack time. This can leave the client and server with different grenade state.
Fix:
Correct the prediction type and tolerances, then network, initialize, save, and predict the next impact attack time.