[ALL] Implement prediction for forced and disabled player input masks - #2031
Open
speedvoltage wants to merge 1 commit into
Open
[ALL] Implement prediction for forced and disabled player input masks#2031speedvoltage wants to merge 1 commit into
speedvoltage wants to merge 1 commit into
Conversation
Network forced and disabled input masks to the owning client. Apply them to a stack copy during prediction so the command ring and verified checksum remain untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The server can force or disable player buttons without telling the owning client. The client then predicts movement using inputs that the server changes.
Fix:
Send the button masks to the owning client and apply them to a copy of the command without modifying the original command or its checksum.