Repository navigation
fix: reconcile the saved agent model from the submitted connection (WI-1804) - #429
Merged
Merged
Conversation
…(WI-1804) saveModel sent the selected connection but its completion handler reread the mutable modelConnectionId. Selecting a different connection while the request was in flight recorded the newer one as saved, so the UI showed it active and disabled Save while the server still used the submitted model. Capture the submitted connection and reconcile the saved state, summary, and indicator from it; a newer selection stays unsaved and keeps Save enabled. Add stable test ids for the model summary and the saved indicator.
|
Size Change: 0 B 🆕 Total Size: 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saveModelsent the selected connection but its completion handler reread the mutablemodelConnectionId. Selecting a different connection while the request was in flight recorded the newer one as saved, so the UI showed it active and disabled Save while the server still used the submitted model.Change
Capture the submitted connection and reconcile the saved state, model summary, and saved indicator from it. A newer selection stays unsaved and keeps Save enabled. Adds stable
data-testids for the model summary and the saved indicator.Tests
Windshiftapp/core-tests-internal#30 — a Playwright regression with a delayed response; fails against the pre-fix component with Save disabled.