Skip to content

fix: reconcile the saved agent model from the submitted connection (WI-1804) #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan-ernst merged 1 commit into from
Nov 2, 2026
Merged

fix: reconcile the saved agent model from the submitted connection (WI-1804) #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions frontend/src/lib/features/agents/AgentProfile.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,29 +451,33 @@

async function saveModel() {
if (!canAdmin || !adminProfile || !modelChanged || savingModel) return;
// Capture the submitted connection. A selection made while the request is
// in flight must not be recorded as saved when it completes; it stays
// unsaved and modelChanged keeps the Save button enabled.
const submittedConnectionId = Number(modelConnectionId);
savingModel = true;
modelSaved = false;
actionError = '';
try {
await agentBindings.updateAgentConfig(workspaceId, agentId, {
instructions: adminProfile.instructions || '',
skill_ids: adminProfile.skill_ids || [],
llm_connection_id: Number(modelConnectionId),
llm_connection_id: submittedConnectionId,
});
const nextVersion = markNewDraftVersion();
const connection = llmConnections.find(
(candidate) => Number(candidate.id) === Number(modelConnectionId)
(candidate) => Number(candidate.id) === submittedConnectionId
);
adminProfile = {
...adminProfile,
llm_connection_id: Number(modelConnectionId),
llm_connection_id: submittedConnectionId,
profile_version: nextVersion,
};
agent = {
...agent,
model_summary: connection?.model || agent.model_summary,
};
modelSaved = true;
modelSaved = Number(modelConnectionId) === submittedConnectionId;
await checkReadiness();
} catch (err) {
actionError = err.message || 'The model could not be changed.';
Expand Down Expand Up @@ -772,7 +776,7 @@
<p class="mt-2 text-sm" style="color: var(--ds-text-subtle);">
{label(agent.runtime)} runtime
</p>
<p class="mt-1 text-sm" style="color: var(--ds-text-subtle);">
<p class="mt-1 text-sm" style="color: var(--ds-text-subtle);" data-testid="agent-model-summary">
{agent.model_summary || 'Model unavailable'}
</p>
</div>
Expand Down Expand Up @@ -1123,11 +1127,12 @@
</Button>
</div>
{#if modelSaved}
<AlertBox
variant="success"
message="Model changed. The profile is now a Draft and must be made Ready again."
class="mt-3"
/>
<div class="mt-3" data-testid="agent-model-saved">
<AlertBox
variant="success"
message="Model changed. The profile is now a Draft and must be made Ready again."
/>
</div>
{/if}
</div>
{#if agent.profile_type === 'standard'}
Expand Down
Loading