Release LSP, MCP, and many other changes

.config/dotnet-tools.json

@@ -0,0 +1,13 @@
+{
+  "version": 1,
+  "isRoot": true,
+  "tools": {
+    "nbgv": {
+      "version": "3.10.94",
+      "commands": [
+        "nbgv"
+      ],
+      "rollForward": false
+    }
+  }
+}

.editorconfig

@@ -0,0 +1,19 @@
+root = true
+
+[*.cs]
+
+# S125: Sections of code should not be commented out
+# Commented-out code is used deliberately throughout this codebase (asm-mirroring
+# notes, disabled diagnostics, WIP scaffolding) -- suppress project-wide.
+dotnet_diagnostic.S125.severity = none
+
+# S6640: Using "unsafe" code blocks is security-sensitive
+# Unsafe code is unavoidable here -- native interop, pinned emulator state, raw
+# memory spans over the core's buffers -- suppress project-wide.
+dotnet_diagnostic.S6640.severity = none
+
+# S3776: Cognitive Complexity of methods should not be too high
+# Emulator dispatch, opcode handling and DAP request handlers are inherently
+# branchy; splitting them for the metric's sake hurts readability -- suppress
+# project-wide.
+dotnet_diagnostic.S3776.severity = none

.gitignore

@@ -29,3 +29,5 @@ test.zip
 publish.bat
 *- Backup.*
 *.ods
+*.log
+CLAUDE.md

.gitmodules

@@ -28,3 +28,9 @@
 [submodule "BitMagic.Examples"]
 	path = BitMagic.Examples
 	url = https://github.com/Yazwh0/BitMagic.Examples.git
+[submodule "External/BitMagic.ZiModem"]
+	path = External/BitMagic.ZiModem
+	url = https://github.com/Yazwh0/BitMagic.ZiModem.git
+[submodule "BitMagic.X16MCP"]
+	path = BitMagic.X16MCP
+	url = https://github.com/Yazwh0/BitMagic.X16MCP.git

BitMagic.sln

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 17
-VisualStudioVersion = 17.4.33403.182
+# Visual Studio Version 18
+VisualStudioVersion = 18.9.12112.369
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "X16D", "BitMagic.X16Debugger\X16D\X16D.csproj", "{1A61AC4C-C457-44E1-844D-DE1E5FCCF6E2}"
 EndProject
@@ -99,6 +99,16 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "BitMagic.ImageHelper.Tester
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "X16KernelTokenGenerator", "BitMagic.X16Debugger\X16KernelTokenGenerator\X16KernelTokenGenerator.csproj", "{315F6888-5BEC-4C36-811C-CB162EA85EFE}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "ZiModem", "ZiModem", "{EA9A9461-65C5-4A08-AC88-D691CA7E6D96}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ZiModem.Net", "External\BitMagic.ZiModem\managed\ZiModem.Net\ZiModem.Net.csproj", "{169D0060-163E-95B7-FD6B-8E961F82C176}"
+EndProject
+Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "ZiModemHost", "External\BitMagic.ZiModem\native\ZiModemHost.vcxproj", "{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}"
+EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "BitMagic.X16Debugger", "BitMagic.X16Debugger", "{97EF9954-7ECC-2AD4-D902-769250895DF7}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "BitMagic.X16Debugger.Tests", "BitMagic.X16Debugger\BitMagic.X16Debugger.Tests\BitMagic.X16Debugger.Tests.csproj", "{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -481,6 +491,40 @@ Global
 		{315F6888-5BEC-4C36-811C-CB162EA85EFE}.Release|x64.Build.0 = Release|Any CPU
 		{315F6888-5BEC-4C36-811C-CB162EA85EFE}.Release|x86.ActiveCfg = Release|Any CPU
 		{315F6888-5BEC-4C36-811C-CB162EA85EFE}.Release|x86.Build.0 = Release|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Debug|x64.Build.0 = Debug|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Debug|x86.Build.0 = Debug|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Release|Any CPU.Build.0 = Release|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Release|x64.ActiveCfg = Release|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Release|x64.Build.0 = Release|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Release|x86.ActiveCfg = Release|Any CPU
+		{169D0060-163E-95B7-FD6B-8E961F82C176}.Release|x86.Build.0 = Release|Any CPU
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Debug|Any CPU.ActiveCfg = Debug|x64
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Debug|Any CPU.Build.0 = Debug|x64
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Debug|x64.ActiveCfg = Debug|x64
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Debug|x64.Build.0 = Debug|x64
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Debug|x86.ActiveCfg = Debug|x64
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Release|Any CPU.ActiveCfg = Release|x64
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Release|Any CPU.Build.0 = Release|x64
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Release|x64.ActiveCfg = Release|x64
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Release|x64.Build.0 = Release|x64
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1}.Release|x86.ActiveCfg = Release|x64
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Debug|x64.Build.0 = Debug|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Debug|x86.Build.0 = Debug|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Release|Any CPU.Build.0 = Release|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Release|x64.ActiveCfg = Release|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Release|x64.Build.0 = Release|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Release|x86.ActiveCfg = Release|Any CPU
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7}.Release|x86.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -515,6 +559,10 @@ Global
 		{CF8BC7BD-5BBA-48D2-A334-747D0D11FFB3} = {25ADB53E-2320-490D-BA5D-A919AF7B42E5}
 		{B47D2EDF-10E7-477B-B0FF-C308AC152CE1} = {25ADB53E-2320-490D-BA5D-A919AF7B42E5}
 		{315F6888-5BEC-4C36-811C-CB162EA85EFE} = {A8C28097-0281-4E86-BEA0-8864A21B72B9}
+		{EA9A9461-65C5-4A08-AC88-D691CA7E6D96} = {56C1711B-E0BB-40B0-BAF6-77E3206969A6}
+		{169D0060-163E-95B7-FD6B-8E961F82C176} = {EA9A9461-65C5-4A08-AC88-D691CA7E6D96}
+		{7E3EFF57-92D4-4994-8681-7D99B3F5A5A1} = {EA9A9461-65C5-4A08-AC88-D691CA7E6D96}
+		{C44DD593-D0B9-47B0-B3F6-58E02C55A5D7} = {97EF9954-7ECC-2AD4-D902-769250895DF7}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {DFCB7DF5-52B3-4B9B-9814-3EC16549A76F}

Directory.Build.props

@@ -1,16 +1,38 @@
 <Project>
+  <!--
+    Shared NuGet packaging metadata (only takes effect for a project that sets
+    IsPackable/PackAsTool, e.g. X16M.csproj): these used to be raw .nuspec element
+    names (<id>, <license>, <icon>, <dependencies>) pasted into an MSBuild PropertyGroup,
+    which SDK-style `dotnet pack` doesn't read at all. PackageId has no sensible shared
+    default (every packable project must set its own, as X16M.csproj already does);
+    Owners has no effect under SDK-style packing (nuget.org derives ownership from the
+    account that pushes, not the nuspec); the icon path pointed at a NugetProject\ folder
+    that is dead leftover scaffolding with no butterfly.jpg in it; and <dependencies> is
+    always auto-generated correctly by the SDK from each project's actual
+    PackageReference/TargetFramework. All four were silently doing nothing.
+  -->
   <PropertyGroup>
-    <id>BitMagic</id>
-    <version>0.1.0</version>
-    <title>BitMagic X16 Emulator and Debugger</title>
-    <authors>Yazwh0</authors>
-    <owners>Yazwh0</owners>
-    <license>AGPL-3.0-or-later</license>
-    <description>X16 Emulator and Debugger</description>
-    <icon>NugetProject\butterfly.jpg</icon>
-    <dependencies>
-      <group targetFramework="net6.0" />
-    </dependencies>
+    <Version>0.1.0</Version>
+    <Title>BitMagic X16 Emulator and Debugger</Title>
+    <Authors>Yazwh0</Authors>
+    <Description>X16 Emulator and Debugger</Description>
+    <!-- The repo's actual LICENSE files are plain GPL-3.0 text (confirmed against every
+         submodule's LICENSE and GitHub's own "gpl-3.0" detection on the superproject),
+         not AGPL-3.0-or-later as this used to (ineffectually) claim. PackageLicenseFile,
+         not just a PackageLicenseExpression string, so the actual license text ships
+         inside the package rather than just an SPDX tag. -->
+    <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <GenerateAssemblyInfo>true</GenerateAssemblyInfo>
   </PropertyGroup>
+
+  <!-- NuGet requires the packaged license file to have a .txt/.md extension (NU5030),
+       hence LICENSE.txt rather than the extensionless LICENSE some tools default to.
+       PackagePath="\" (matching the working README.md item in X16M.csproj) keeps the
+       source's own file name. An explicit rename via PackagePath (e.g. "LICENSE.txt" for
+       a source file just named LICENSE) nests the file under a same-named subfolder
+       instead, for a multi-RID pack like X16M's; confirmed by inspecting the generated
+       .nuspec. Renaming the source file itself sidesteps it entirely. -->
+  <ItemGroup>
+    <None Include="$(MSBuildThisFileDirectory)LICENSE.txt" Pack="true" PackagePath="\" />
+  </ItemGroup>
 </Project>

version.json

@@ -0,0 +1,4 @@
+{
+  "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/main/src/NerdBank.GitVersioning/version.schema.json",
+  "version": "0.1"
+}