Skip to content

[PR-16] Readiness That Reflects Serving Capability #384

Closed as not planned
Closed as not planned

Description

@amuraru

Delivery bundle: D: HA and secure deployment. See #395 and #368 for the four-PR stack.

Parent: #392
Roadmap: #368
Plan item: PR-16
Priority: P2
Dependencies: PR-06

Kubernetes support: Rolling upstream-maintained minors; use the oldest/newest boundaries pinned in config/kubernetes-versions.env. See #368 for the current policy. Unrun jobs are not passed validation.

Problem Statement

Evidence: main.go:169-177 registers healthz.Ping for readiness and liveness.

Proposed Solution

Files: main.go, manager readiness tests, relevant HTTP lifecycle code from PR-06, deployment probe configuration, and documentation.

Interface contract: Liveness remains lightweight and independent of Kafka reachability. Readiness includes WebhookServer.StartedChecker() when enabled and any nonblocking cache/index readiness needed by admission. Standby webhook-serving replicas remain ready.

  • Add tests for webhook not started, usable serving endpoint, missing required admission cache/index, disabled webhooks, and nonleader replicas.
  • Add a Kafka outage test asserting it does not cause liveness restart loops.
  • Integrate readiness with PR-06's alert-serving model without making all endpoints leader-only or rejecting healthy webhook standbys.
  • Validate focused manager tests and Kind rollout/failover tests with admission traffic.

Done when: Service endpoints represent usable serving instances without coupling operator liveness to operand outages.

Delivery: Four consolidated PRs, approved November 16, 2026: A -> B -> C; D branches from A. Foundation is #395. The 22 PR-XX identifiers are work-item IDs, not separate PRs. Preserve every work-item acceptance criterion and native dependency. No gated experiment is automatically enabled, and no issue is complete merely because one PR references it. D must satisfy its native #375 gate, including lifecycle-domain signals assigned to B; branching from A does not waive that merge prerequisite. Write focused regression tests first; record exact commands/results and run make check plus this issue's real-cluster/measurement gates.

Alternatives Considered

Twenty-two individual PRs add unnecessary integration overhead, while one omnibus PR obscures correctness and rollout boundaries. Deliver this scope in its approved dependency-aligned bundle. Do not expand into deferred consistency, storage, or concurrency changes without their own decision gates.

Additional Context

Baseline: 95138e0d; detailed roadmap scope: #368, section PR-16. The roadmap #368 and its native sub-issues are the planning source of truth. No planning document is committed in the final PR diffs. Re-read affected source and overlapping work before implementation. Historical baseline test passes are not validation of this change.

Activity

  1. added theissue type on Nov 16, 2026
  2. amuraru commented on Nov 17, 2026

    @amuraru
    Author

    Serving-aware readiness moves to #392 under #368. Preserve usable webhook standbys and Kafka-independent liveness; no broad metrics prerequisite. Superseded, not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions