Repository navigation
Housekeeping: dependency bumps, lint debt, finished TODOs, dependabot - #83
Merged
Merged
Conversation
Tomer Glottmann (tomergee)
force-pushed
the
chore/housekeeping-2026-10-13
branch
from
October 13, 2026 21:20
0638c63 to
5f347fc
Compare
Tomer Glottmann (tomergee)
force-pushed
the
chore/housekeeping-2026-10-13
branch
3 times, most recently
from
October 14, 2026 00:00
c1deafd to
dac39f4
Compare
Sunny (sunnylovestiramisu)
approved these changes
Oct 14, 2026
Build, vet and the full suite pass on the new versions; no code changes were needed.
- The three multi-line CLI error strings in manifest.go ended with a period, which staticcheck flags (ST1005); dropped. - clients/python gets a ruff configuration (pyflakes, non-layout pycodestyle, import order, pyupgrade for the 3.10 floor; generated stubs excluded), the one finding it produces is fixed, ruff is in the dev extra, and CI runs `ruff check clients/python` after the tests.
…dependabot - env.proto: three of the four TODO(jbd) notes describe work that is done (the data plane lives in guest.proto, the REST lifecycle endpoints are gone, docs were updated); only ListEnvironments remains. client.go: the two atespace TODOs are done, atespace is a parameter everywhere. - Python stubs regenerated for the proto comment change. The generator is grpcio-tools 1.84, which stamps GRPC_GENERATED_VERSION 1.84.0 and makes the import-time check require grpcio >= 1.84; the client's and the nemo-gym integration's floors move from 1.83 to 1.84 to match. - docs/release.md says rootfs-image templates, the name since #70. - .github/dependabot.yml: weekly grouped updates for the Go module, the two Python projects and the workflow actions. The Substrate module is excluded: its bumps change the generated API and go through the bump procedure, not an automated PR.
The fleet, driver, runtime, strategies, config and their tests arrived after the ruff gate in this PR was written and carry 198 findings under its configuration. All mechanical: PEP 585/604 annotations (list[str], X | None) and typing imports moved to collections.abc, which the 3.10 floor and the future import already allow; unused imports and import order in tests; quoted annotations. Two by hand: backend/mock.py used Any without importing it, and client.py had `import collections` below a function. `uv run --extra dev pytest`: 118 passed. `ruff check clients/python`: clean.
Tomer Glottmann (tomergee)
force-pushed
the
chore/housekeeping-2026-10-13
branch
from
October 14, 2026 16:29
dac39f4 to
a384a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from a repo health pass over
mainat 077ae95, rebased onto 490130e after #80. Four commits, each self-contained.1. Dependencies
modelcontextprotocol/go-sdk1.4.1 → 1.8.0,grpc1.83.2 → 1.84.0,k8s.io/{api,apimachinery}0.37.0 → 0.37.1. Build, vet and the full suite pass; no code changes were needed.2. Lint debt the coming gates would surface
cmd/ate-env/manifest.goended with a period. Dropped; the tests match substrings only.clients/python: a configuration (pyflakes, non-layout pycodestyle, import order, pyupgrade for the 3.10 floor; generated stubs excluded), the one finding it produces fixed,ruffpinned in the dev extra, and CI runsruff check clients/pythonafter the tests. The nemo-gym integration is left for after integrations/nemo-gym: port to the current client, derive templates from images, run the tests in CI #82 lands, which rewrites its files.3. Finished TODOs, wording, grpcio floor, dependabot
env.proto: three of the fourTODO(jbd)notes describe done work (data plane inguest.proto, REST lifecycle endpoints gone, docs updated); onlyListEnvironmentsremains.internal/ate/client.go: the two atespace TODOs are done.GRPC_GENERATED_VERSION = 1.84.0and makes the import-time check require grpcio ≥ 1.84; both Python projects' floors move from 1.83 to 1.84 to match. (This is the check fix(python): soften grpc generated version check in proto stubs #81 tried to soften; the floor is the right lever.)docs/release.md: "task-image templates" → "rootfs-image templates"..github/dependabot.yml: weekly grouped updates for the Go module, the Python client and the workflow actions. The Substrate module is excluded on purpose: its bumps change the generated API and go through the bump procedure. The nemo-gym integration is not listed: itsate-env-clientdependency is a path source Dependabot cannot resolve, and nothing in it is pinned. Each update has a 7-day cooldown, which the organization's zizmor check requires (dependabot-cooldown).4. ruff pass over the SDK merged in #80
The fleet, driver, runtime, strategies, config and their tests landed after the gate in commit 2 was written and carry 198 findings under it. All mechanical: PEP 585/604 annotations, typing imports moved to
collections.abc, unused imports and import order in tests, quoted annotations. Two by hand:backend/mock.pyusedAnywithout importing it, andclient.pyhadimport collectionsbelow a function. 118 tests pass after it.Testing
go build,go vet,go test ./...,make verify-gofmt verify-boilerplate, staticcheck clean,buf generateno diff, Python client 73 tests,ruff checkclean, zizmor clean on the workflows.Not here
The Substrate bump to today's main (13 commits past the pin;
HTTPGetActionis nowHttpGetAction) is its own PR next.