Repository navigation
fix(codex): list pool accounts without a native home - #1
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
@codex review |
|
@cursor review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09e092bf6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@cursor review |
|
@codex review Please review current head |
|
@cursor review Please review current head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6f9a3b124
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review current head |
|
@cursor review Please review current head |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 437939f. Configure here.
Summary
CODEX_HOME_UNAVAILABLEand failed the entire account list.Verification
Current head
437939f19642ef26c0450b85d005555e44ef3daeCODEX_HOME_UNAVAILABLEonly whencodexHomeIsAbsent(getCodexHome())proves absence. Non-directory default homes, dangling links, and parent traversal failures still report errors. Existing unavailable/busy-claim behavior and credential-mutation checks are unchanged.bun scripts/test.ts tests/codex-integration/codex-auth-headless-accounts.test.ts tests/codex-integration/codex-auth-api.test.ts tests/codex-integration/native-profile-store.test.ts tests/codex-integration/codex-home-owner.test.ts tests/lab/core-lab-boundary.test.ts: 434 passed, 0 failed. After the WSL-only fixture correction, the complete headless file was rerun with the red/green results above; runtime code was unchanged.bun scripts/test.ts --changed=HEAD, run before committing againstb6f9a3b124995b6e909e8fa8187c633bcb276e43: 33,052 passed, 40 skipped, 1 failed across 1,468 files. The sole failure,connected-client runtime probe scope > a rejected preferred runtime falls back without rewriting the saved selection, is the already reproduced host Codex discovery leak. Recheckingtests/cli/cli-connect-readiness.test.tswith the documented process-only isolation profile passed 27 tests, 1 skipped, 0 failed; assertions and host configuration were unchanged.bun node_modules/typescript/bin/tsc --noEmit,bun scripts/privacy-scan.ts,bun scripts/structure-ssot.ts, andgit diff --checkpassed.cd docs-site && bun install --frozen-lockfilepassed with no dependency changes;bun --bun run buildpassed with 585 pages and 83,065 internal links checked.ci. Codex, Bugbot, and upstream CodeRabbit completed without remaining findings. Fork PR fix(codex): list pool accounts without a native home #1 was squash-merged intoalexalok/opencodex:devas4abfcc6d0c26b4444469833de67f216851f18882; its feature branch is preserved for upstream PR fix(codex): list pool accounts without a native home lidge-jun/opencodex#7450. Upstream required CI still awaits maintainer approval. Older-head evidence below remains historical.Runtime validation at
22a9f85e85f70ab6d7d81dd8b31af4765aa26863OPENCODEX_HOMEnow reportsPROFILE_STORAGE_UNSAFEeven whenCODEX_HOMEis absent, including if the home disappears during quota refresh. No credential-write checks were relaxed.codex-auth-headless-accounts.test.ts,codex-auth-api.test.ts,native-profile-store.test.ts, andnative-profile-manager.test.ts, undertests/codex-integration/.bun scripts/test.ts --changed=dev(Bun 1.4.3, merge base12025981e5a304cdb6b1b54f525ba8554f623977): 34,169 passed, 42 skipped, 2 failed across 1,527 files. The two failures are the previously reproduced host-runtime leaks:resolveCodexRuntime > treats missing persisted and resolved versions as the same selectionandconnected-client runtime probe scope > a rejected preferred runtime falls back without rewriting the saved selection.sandbox-exec -f /tmp/opencodex-test-isolation.sb bun scripts/test.ts tests/codex-integration/codex-runtime.test.ts tests/cli/cli-connect-readiness.test.ts: 86 passed, 1 skipped, 0 failed. Assertions and installed tools were unchanged.bun node_modules/typescript/bin/tsc --noEmit,bun scripts/privacy-scan.ts,bun scripts/structure-ssot.ts, andgit diff --check: passed.cd docs-site && bun --bun run build: passed; 585 pages and 83,065 internal links checked.ci, plus the supporting gates. macOS/Windows lanes were skipped by repository policy. This does not substitute for upstream required CI or maintainer approval.Prior implementation validation at
b2a8fb30cdaf8715e4a23b2a5c9aeb458df4868812025981e5a304cdb6b1b54f525ba8554f623977; head:b2a8fb30cdaf8715e4a23b2a5c9aeb458df48688.bun scripts/test.tswith repository-pinned Bun 1.4.3: 51,144 passed, 145 skipped, 7 failed across the parallel suite and serial lanes. All 12 new account-list regression cases passed.12025981ein this same checkout: Desktop remote-hub cold-restart model IDs (1), Codex runtime discovery (1), CLI connect readiness (1), and launcher PATH fallback (3). The seventh was a 5-second crash-guard diagnostic timeout; that file passed on untouched upstream and on an immediate focused rerun of the PR head (18 passed, 0 failed).bun node_modules/typescript/bin/tsc --noEmit: passed.bun scripts/privacy-scan.ts: passed.bun scripts/structure-ssot.ts: passed.cd docs-site && bun --bun run build: passed; 585 pages and 83,065 internal links checked.git diff --check origin/dev...HEAD: passed.b2a8fb3with no findings and no unresolved threads in that prior round.Checklist
The isolation profile and historical full-suite exceptions are documented in upstream PR #7450.
Note
Medium Risk
Touches Codex auth/account-list and native-home resolution on a security-sensitive path; behavior is narrowed with strict fail-closed rules for bad paths and credential mutations, plus broad integration tests.
Overview
Codex account list/refresh no longer fails when the native
CODEX_HOMEis genuinely missing. Stored ChatGPT pool accounts still return from the dashboard andGET/POSTcodex-auth account routes; listing does not create a home or alter cached main identity orneedsReauthstate.Runtime:
isNativeMainObservationUnavailabletreats busy/unavailable claims and proven-absentCODEX_HOMEas “observation skipped” for passive reads (account-list, main quota probe), whilewithNativeMainCredentialClaimstill errors on a missing home for mutations. Invalid explicit/default home paths (file, dangling symlink, untraversable parent) and unsafeOPENCODEX_HOMEstill fail closed; OpenCodex storage is validated before missing-home tolerance.Docs (EN + 7 locales) and structure
openai-accounts.mddocument the boundary. Tests: newcodex-auth-headless-accounts.test.tsand test-layout registration.Reviewed by Cursor Bugbot for commit 437939f. Configure here.