chore(c/validation): remove quirk for float16 ingestion

[fornwall]

Remove the quirk for float16 ingestion - it's better to override the test method and skip it, instead of adding a lot of quirks.

[lidavidm]

You should be able to just override the method and skip/no-op the test.

[fornwall]

You should be able to just override the method and skip/no-op the test.

Ah, missed that possibility as the method is non-virtual (but that is no blocker with the registration macro), and saw the existing supports_ingest_float16() quirk.

• Do you think the existing supports_ingest_float16() should go away for consistency (to avoid giving the impression that it's a good pattern adding more quirks like that)?
• Or perhaps change it to a supports_ingest(ingest_type), if we want to keep quirks here without introducing too many separate quirk methods?
• Or is the current status fine and we should just close this (totally fine by me, overriding is acceptable).

[lidavidm]

I saw the existing quirk too and got confused, it seems it slipped in as part of a larger PR (frankly - eventually I think most of these tests can be removed in favor of the actual validation suite, which is better set up for this, and the C++ suite can be used to focus on ABI/FFI compliance)

[fornwall]

👍 I changed this PR to instead remove the supports_ingest_float16() quirk.