Skip to content

chore(c/validation): remove quirk for float16 ingestion #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Sep 15, 2026
Merged

chore(c/validation): remove quirk for float16 ingestion #4779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions c/validation/adbc_validation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,6 @@ class DriverQuirks {
/// \brief Whether ingestion supports StringView/BinaryView types
virtual bool supports_ingest_view_types() const { return true; }

/// \brief Whether ingestion supports Float16
virtual bool supports_ingest_float16() const { return true; }

/// \brief Default catalog to use for tests
virtual std::string catalog() const { return ""; }

Expand Down
4 changes: 0 additions & 4 deletions c/validation/adbc_validation_statement.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,6 @@ void StatementTest::TestSqlIngestInt64() {
}

void StatementTest::TestSqlIngestFloat16() {
if (!quirks()->supports_ingest_float16()) {
GTEST_SKIP();
}

ASSERT_NO_FATAL_FAILURE(TestSqlIngestNumericType<float>(NANOARROW_TYPE_HALF_FLOAT));
}

Expand Down
Loading