Repository navigation
fix(endpoint): Remove the binding on unbind - #262
Merged
Merged
Conversation
unbind replaced the binding with a new client Cluster instead of deleting it. Incoming commands for that cluster then reached a client handler, which answered UNSUP_CLUSTER_COMMAND, where an endpoint without a binding answers UNSUPPORTED_CLUSTER. Delete the binding, and turn the harness's known-bug test for this into a real one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoint.unbindleft a clientClusterinbindings, so incoming commands for that cluster gotUNSUP_CLUSTER_COMMAND. It now removes the binding, and they getUNSUPPORTED_CLUSTER.