Skip to content

fix(endpoint): Remove the binding on unbind #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinBol merged 1 commit into from
Oct 27, 2026
Merged

fix(endpoint): Remove the binding on unbind #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Endpoint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class Endpoint extends EventEmitter {
*/
unbind(clusterName) {
const OutputCluster = Cluster.getCluster(clusterName);
this.bindings[OutputCluster.NAME] = new OutputCluster(this, OutputCluster);
delete this.bindings[OutputCluster.NAME];
}

/**
Expand Down
26 changes: 11 additions & 15 deletions test/virtualDevice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,22 +145,18 @@ describe('Virtual device: known bugs on master', function () {
);
});

it(
'Endpoint.unbind removes the binding, so the cluster is unsupported',
{ todo: 'unbind leaves a Cluster in bindings' },
async function () {
const { zclNode, virtualDevice } = createVirtualDevice({
endpoints: [{ endpointId: 1, outputClusters: [OnOffCluster.ID] }],
});
zclNode.endpoints[1].bind('onOff', new BoundCluster());
zclNode.endpoints[1].unbind('onOff');
it('Endpoint.unbind removes the binding, so the cluster is unsupported', async function () {
const { zclNode, virtualDevice } = createVirtualDevice({
endpoints: [{ endpointId: 1, outputClusters: [OnOffCluster.ID] }],
});
zclNode.endpoints[1].bind('onOff', new BoundCluster());
zclNode.endpoints[1].unbind('onOff');

await assert.rejects(
virtualDevice.endpoints[1].clusters.onOff.toggle(),
/^Error: UNSUPPORTED_CLUSTER$/,
);
},
);
await assert.rejects(
virtualDevice.endpoints[1].clusters.onOff.toggle(),
/^Error: UNSUPPORTED_CLUSTER$/,
);
});

it(
'a report with an unknown attribute id does not emit attr.undefined',
Expand Down
Loading