Repository navigation
Conversation
Use the apple,apcie phandle instead of searching for a T8140-compatible controller. This allows the shared sleep path to assert J713 radio PERST before removing the native PCIe clocks. Signed-off-by: Erik Bourget <erik@ebourget.net>
erikwb
force-pushed
the
j713/radio-s2r-dart
branch
from
November 9, 2026 20:41
52e3c8a to
3ac93e7
Compare
erikwb
force-pushed
the
j713/radio-s2r-perst
branch
from
November 9, 2026 20:41
f9e9c5e to
170c161
Compare
This was referenced Nov 9, 2026
RyanTheTide
reviewed
Nov 10, 2026
RyanTheTide
left a comment
RyanTheTide
left a comment
Contributor
There was a problem hiding this comment.
The change itself is fine: both t8140.dtsi and t8132.dtsi already give the sleep node apple,apcie = <&pcie0>, the binding documents it, and of_parse_phandle() returns a reference the existing of_node_put() drops, as of_find_compatible_node() did.
The failing kunit job (https://github.com/aurora-silicon/linux/actions/runs/42695306042) is not caused by this commit. It fails to link with undefined symbol: t8132_spmi_va: arch/arm64/kernel/sleep.S on the base (b6f4482, from #1314) references a symbol that only exists with CONFIG_APPLE_T8140_SLEEP=y. It has to be fixed on the base.
Contributor
Author
|
Folded into #1314 (authorship kept), which carries the J713 radio sleep work from here on. Closing in favour of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared sleep path searches for a T8140-compatible PCIe host, so it misses the T8132 host on J713. Follow the sleep controller's
apple,apciephandle instead. This lets the existing sleep sequence assert the shared radio PERST before removing PCIe clocks.Part 2/5 of J713 native radio S2R, stacked on #1314 at
00f5d3e3f848.stack/j713-radio-pr1314mirrors that PR's head so each subsystem has a separate review diff in this repository.Series order: #1378 → #1381 → #1382 → #1383 → #1384.
Depends on #1378.
Validation on this base:
Qualification covers radio recovery in the minimal sleep profile. GPU, external displays and SIO/audio were excluded, SLC allocation remained off, and paired Bluetooth traffic was not tested.