Repository navigation
Conversation
Drain reset work before suspending the managed radio and require completed asynchronous setup. Report the D3 acknowledgment and resume result to the host owner, keeping reset work blocked until both radio functions finish recovery. Preserve the existing path on other hosts. Signed-off-by: Erik Bourget <erik@ebourget.net>
erikwb
force-pushed
the
j713/radio-s2r-pcie
branch
from
November 9, 2026 20:41
16fdcb9 to
c856eff
Compare
erikwb
force-pushed
the
j713/radio-s2r-wifi
branch
from
November 9, 2026 20:41
551002a to
a55ea56
Compare
This was referenced Nov 9, 2026
RyanTheTide
reviewed
Nov 10, 2026
RyanTheTide
left a comment
RyanTheTide
left a comment
Contributor
There was a problem hiding this comment.
The new paths are gated on apple_radio_sleep_owned() and the radio-sleep.h stubs, so other hosts keep the existing suspend/resume behaviour. brcmf_pcie_reset() now clears setup_complete on every host, but only the owned path reads it.
Remaining items:
-
brcmfmac/pcie.cis used on every Apple machine with this radio family. Please add a suspend/resume run on one non-J713 machine showing no change there. -
CI has not run on this head.
This can land only after the rest of the series (#1314, #1378, #1381, #1382).
Contributor
Author
|
Folded into #1314 (authorship kept), which carries the J713 radio sleep work from here on. Closing in favour of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinate brcmfmac with the managed J713 radio host so reset work cannot race the shared PCIe sleep transaction. Drain reset work, require completed asynchronous setup, and report the firmware D3 acknowledgment and resume result. Reopen reset work only after both radio functions finish recovery.
Aborted suspend can overlap an asynchronous setup failure and driver unbind. Serialize deferred cleanup with the endpoint device lock and require the same driver binding to own the pending cleanup. A threaded regression covers removal ordering, replacement bindings and repeated completion; other hosts retain their existing path.
Part 4/5 of J713 native radio S2R, stacked on #1314 at
00f5d3e3f848.stack/j713-radio-pr1314mirrors that PR's head so each subsystem has a separate review diff in this repository.Series order: #1378 → #1381 → #1382 → #1383 → #1384.
Depends on #1382.
Validation on this base:
Qualification covers radio recovery in the minimal sleep profile. GPU, external displays and SIO/audio were excluded, SLC allocation remained off, and paired Bluetooth traffic was not tested.