Repository navigation
tools/asahi: extract the AV1 reference guard in the AV1 tail host test - #754
Merged
Merged
Conversation
avd-av1-tail-tests.py builds avd_av1_set_prob() and friends from avd-av1.c on the host. Since "media: apple: avd: bound AV1 reference indices before using them", those functions call avd_av1_ref_ts(), a u64 helper the extractor did not pick up, so the generated file stopped compiling and run-host-tests went from 158/158 to 148/158. Extract avd_av1_ref_ts() too (the function matcher now accepts a u64 return type) and give the host prelude u64 and U64_MAX. The production controls pass again and all six mutations are still caught. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #725,
run-host-testson aurora-wip has been 148/158. The ten failures are allavd-av1-tail-tests. #725's AV1 reference guard addedavd_av1_ref_ts(), au64helper thatavd_av1_set_prob()andavd_av1_run_preamble()now call. The test extracts those functions onto the host but did not pick up the helper, so the generated file stopped compiling.This is a test-only change. The extractor's function matcher now accepts a
u64return type and extractsavd_av1_ref_ts()as well, and the host prelude gainsu64andU64_MAX. Driver code is untouched.Tests on 65a2821 (aurora-wip, files unchanged at d24c57f), on the buildbox:
avd-av1-tail-tests.py: 1804 production controls PASS.round-up,cpu-unaligned,seg-cpu-unaligned,seg-any-size,ref-index-upper,frame-width-unchecked) are still caught (rc 250).tools/asahi/run-host-tests.py --jobs 8: 158/158 passed.🤖 Generated with Claude Code