Skip to content

feat: design v1 - #459

Draft
az3ta wants to merge 15 commits into
mainfrom
dev-design
Draft

az3ta wants to merge 15 commits into
mainfrom
dev-design

Conversation

@az3ta

@az3ta az3ta commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Change

Describe the problem and what this changes. Link the relevant issue, if any.

Validation

List checks run and anything not verified. Include screenshots for UI changes.

az3ta and others added 2 commits October 31, 2026 17:37
Packaging repairs ahead of the design-system work, no visual change intended.

- package.json: replace the glob in the "./assets/*" export, which Node
  cannot resolve, with a plain subpath mapping; add a test script.
- globals.css: drop the two @source globs that pointed at non-existent
  packages/apps and packages/components; give --font-sans/--font-mono
  real fallback stacks; move the dark body gradient out of the package.
- Apps no longer alias @avoid.quest/ui/* into the package source, so
  TypeScript resolves through the real exports map.
- Radio loads Geist Sans/Mono through a new src/styles/app.css entry;
  Web keeps its gradient in its own global.css.
- Remove ten components with no consumers (skeletons, user-avatar,
  mode-toggle, site-logo, item, hover-card, avatar, progress,
  aspect-ratio, carousel) and their dependencies.
- Move the Knob, Slider and Changelog behaviour tests into the package;
  load Radix after the JSDOM globals so portals mount across files.
- field.tsx: skip errors with an undefined message instead of rendering
  an empty bullet.
- root-error-view: render Button as the Link instead of nesting two
  interactive elements.

Changelog: skip

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…445)

* feat(ui): Add Storybook with browser-run interaction and a11y tests

Storybook 10 (react-vite) lives inside packages/ui so it travels with
the package when it is extracted. Tailwind v4 is wired through
viteFinal, light/dark through addon-themes plus a next-themes provider,
and addon-a11y runs axe as a failing check on every story.

Stories cover the components the Base UI migration will touch most:
button, form controls, select, overlays (dialog, menu-to-dialog focus
return, drawer, popover, tooltip), tabs, accordion, scroll area,
sliders, knob, badges, alerts, loading and empty states.

`bun run --filter @avoid.quest/ui test:stories` runs every story's play
function in headless Chromium via the Vitest addon. Two Radix gaps are
recorded in the stories rather than hidden: the select listbox and
popover need an explicit label, and the scroll-area viewport is not
keyboard focusable.

Changelog: skip

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* docs(ui): Record how the dev-ui performance work changes the migration plan

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(ui): Run Storybook accessibility checks in both themes

* test(ui): Cover cancelable loading and gate both themes in CI

* test(ui): Assert theme palettes and disabled button state

* test(radio): Stop deck context mocks leaking between tests

Use the real DeckProvider for transport markup tests. Bun module mocks persist across files, so the mocked context could replace the live progress test context and prevent transport updates depending on test order.

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
d957216 2026-11-03T17:38:31.413Z View logs ↗
  • Build: Failed ❌

View logs ↗
a0dae27 2026-11-03T17:34:25.319Z View logs ↗
  • Build: Failed ❌

View logs ↗
db38767 2026-10-31T20:34:03.847Z View logs ↗
  • Build: Failed ❌

View logs ↗
c833a76 2026-10-31T19:23:22.583Z View logs ↗
  • Build: Failed ❌

View logs ↗
4d29a6a 2026-10-31T18:30:15.713Z View logs ↗
  • Build: Failed ❌

View logs ↗
10e1f43 2026-10-31T16:39:25.281Z View logs ↗

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://dev-design-radio.cwav.workers.dev (commit f2d2436)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://52eb946b-radio.cwav.workers.dev f2d2436 2026-11-04T19:03:51.824Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://ad8cb580-radio.cwav.workers.dev 189d66a 2026-11-03T21:39:21.644Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://6c379788-radio.cwav.workers.dev f7800cc 2026-11-03T19:35:06.342Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://42f438aa-radio.cwav.workers.dev b67d4c6 2026-11-03T19:11:45.846Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://c0dbb8ba-radio.cwav.workers.dev 7f2f3d4 2026-11-03T18:17:42.861Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f5da0ec7-radio.cwav.workers.dev d957216 2026-11-03T17:38:25.418Z Visit the dashboard ↗
  • Build: Failed ❌

View logs ↗
bd6d0c8 2026-10-31T23:25:08.802Z View logs ↗
  • Build: Failed ❌

View logs ↗
db38767 2026-10-31T20:34:38.326Z View logs ↗
  • Build: Failed ❌

View logs ↗
c833a76 2026-10-31T19:23:43.752Z View logs ↗
  • Build: Failed ❌

View logs ↗
4d29a6a 2026-10-31T18:30:30.616Z View logs ↗

View all previews: View all previews ↗

az3ta and others added 5 commits October 31, 2026 19:29
- Re-export `toast` from the shared UI package and update radio imports
- Remove radio’s direct Sonner dependency and delete obsolete web UI config
* feat: Make small labels and status colours easier to read

Use standard Tailwind text sizes and shared success, warning, info and destructive colours across the apps and UI library. Add accessible light/dark state examples and let EQ bands wrap in narrow racks.

Refs NWS-2784. Bespoke theme cleanup awaits Francesco's confirmation; replacement base values, radius and fonts await a chosen design source.

* feat: Refresh the player's colours and typography

Apply the Zinc palette and Geist Mono Variable font from shadcn preset beXRToEi, with pointer cursors. Remove bespoke dark gradients, focus overrides and unused utilities. Keep semantic state colours and reduced-motion support.

Verify preset backgrounds and actual font loading in light/dark Storybook. Use full-opacity destructive alert descriptions to preserve contrast with the selected palette.

Refs NWS-2784.

* refactor(radio): use semantic colour tokens directly

Replace meter colour aliases and inline gradients with Tailwind utilities and peak-state variants. Reference shared semantic colours directly in node styles instead of keeping local aliases.

Refs NWS-2784.

* docs: add light and dark theme previews
- Move Storybook ownership and story testing into a dedicated workspace
- Add component and Radio stories with offline fixtures
- Improve light-mode inline error contrast
* refactor(ui): migrate button composition to Base UI (NWS-2789)

Changelog: skip

* refactor(ui): migrate state controls to Base UI (NWS-2790)

Changelog: skip

* refactor(ui): migrate tabs and disclosure panels to Base UI (NWS-2791)

Changelog: skip

* refactor(ui): migrate tooltip and popover to Base UI (NWS-2792)

Changelog: skip

* refactor(ui): migrate menus and selects to Base UI (NWS-2793)

Changelog: skip

* refactor(ui): migrate dialogs and preserve focus return (NWS-2794)

Changelog: skip

* refactor(ui): migrate sliders and scrolling, remove Radix dependencies (NWS-2795)

Changelog: skip

* fix(ui): preserve open context submenu highlighting
* docs(radio): add screen structure proposal

* docs(radio): link structure proposal slices to issues

* docs(radio): align player add-station entry with Settings pages

Changelog: skip

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@az3ta az3ta changed the title Dev design feat: design v1 Nov 1, 2026
az3ta and others added 8 commits November 3, 2026 18:33
* chore(ui): reset UI components and theme to shadcn Sera

Regenerate the shared UI components from the base-sera registry (button, card,
input, textarea, alert, skeleton, spinner, separator, collapsible, scroll-area,
resizable, toggle-group, field, empty, tabs, dialog, popover, select, menus,
accordion, badge, sonner) and import shadcn/tailwind.css with the Sera radius
scale. Keep the local behaviour on top: toast-layer guards on dialog and
popover, menu return focus, the select xs size, the toast re-export and
ResizablePanelHandle. Checkbox, switch, radio-group, toggle, label, tooltip,
slider and the vaul drawer keep their current source, which already matches
Sera or carries local fixes.

Replace arbitrary values with tokens where Tailwind has one (ring-3,
text-caption, -bottom-1.25, w-25, hover:bg-secondary/80).

Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* chore(radio): replace Lucide icons with Tabler

Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* chore(radio): drop rounded-full from skeletons, import preview and deck transport

Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* fix(ui): restore behavior dropped by the Sera regeneration

Restores tabs orientation and activateOnFocus, scroll-area max height and
content wrapper, dialog height cap, toggle-group pressed state and style
merge, collapsible and accordion height transitions, separator decorative
role, dropdown closeOnClick, select list labels and wrapping, popover
positioning props, field error trim, muted volume icon, and moves shadcn to
dependencies so builds can resolve its CSS. The changelog test now fakes
animation frames so it passes on its own.

Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* fix(ui): make story tests pass with the Sera components

Darkens the light destructive colour for 4.5:1 contrast, restores the
disabled accordion opacity, context-menu closeOnClick and the open submenu
highlight.

Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Keep the provider-based deck transport test and main's fixture naming while preserving the design branch changes.

Changelog: skip
- Make the phone canvas the only Node view; keep settings in the inspector drawer
- Remove Stage components and tests, and update Node Mode docs
- Mark temporary stations as unsaved and clarify saving to My stations
- Rename settings, backup, mixer, and patch controls for clearer context
* feat(radio): add station shortcuts to player views

- Open the Add station editor from empty states and the station list
- Share the station editor with Settings and add regression coverage

* test(radio): cover adding stations in the player

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant