Skip to content

Configure no timetable mirrors while GTT blocks CI runners - #23

Merged
fcastrovilli merged 1 commit into
mainfrom
chore/timetable-mirrors-off
Nov 2, 2026
Merged

fcastrovilli merged 1 commit into
mainfrom
chore/timetable-mirrors-off

Conversation

@fcastrovilli

@fcastrovilli fcastrovilli commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

 src/transit-data/config.ts
-TIMETABLE_MIRRORS = [GitHub Pages, rolling `gtt-timetable` prerelease]
+TIMETABLE_MIRRORS = []   // GTT refuses connections from GitHub-hosted runners
 src/services/notices.ts
-"…versioni più recenti … vengono scaricate da avoid-quest.github.io, github.com, …"
+"…gli aggiornamenti arrivano con le nuove versioni dell'app; … l'app legge da gtt.to.it solo l'elenco corse e i calendari…"

The optional timetable freshness layer cannot run in GitHub Actions: www.gtt.to.it refuses TCP connections from GitHub-hosted runners. With no mirror configured, phones make no mirror requests (no IP exposure for nothing). Live boards are unaffected: the bundled package, the direct GTT identity remap and GTT realtime do not depend on mirrors. "Aggiorna orari" still retries the remap. The pipeline and workflow stay in the repo (workflow disabled) for a future host that can reach GTT.

Evidence

  • Before: workflow run 41364495321 failed twice in "Download (conditional), compact, validate" with URLError: <urlopen error timed out>; the same URL answered 200 in 59 ms from an Italian connection.
  • After: bun run verify → typecheck, lint, 434 tests; updateSupported is false with an empty list and no manifest request is made.

Merge Danger

Door: two-way

Re-adding the mirror entries restores the previous behaviour.

Blast Radius: transit-data

Only the optional manifest/package refresh; boards and remap unchanged.


Summary by cubic

Disables the timetable mirror configuration because GTT's static-export host refuses connections from GitHub-hosted runners, and updates the in-app privacy notice accordingly.

  • With no mirrors configured, devices make no mirror requests; timetable freshness now comes with app releases.
  • The direct GTT identity remap and realtime feed are unaffected, so live boards keep working.
  • The documentation now records why mirrors are off and what re-enabling requires.

Written for commit 17945ca. Summary will update on new commits.

View guided diff Turn on auto-fix

GTT's static-export host refuses connections from GitHub-hosted runners, so
the timetable pipeline cannot build there and the workflow is disabled.
With no mirror configured, devices make no mirror requests: freshness comes
with app releases and rotated trip IDs use the direct GTT identity remap.
The GTT notice now says so instead of naming unused hosts.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T00:07:07.834984Z 17945ca PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@fcastrovilli
fcastrovilli merged commit 67f3ec6 into main Nov 2, 2026
2 of 3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17945ca99d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

* re-enable, publish packages from a host that can reach GTT and list the mirrors here, e.g.
* `{ base: 'https://avoid-quest.github.io/maps/gtt/', layout: 'tree' }`.
*/
export const TIMETABLE_MIRRORS: readonly TimetableMirror[] = [];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep direct-GTT controls available without timetable mirrors

On Android, emptying this list makes ScheduleStatus.updateSupported false, but StopBoardPanel.tsx:47–54 gates the entire settings section on that flag, including the per-stop live-data switch, Wi-Fi preference and manual remap refresh. Repository-wide search confirms these controls have no other UI entry point. Consequently, new users cannot enable per-stop predictions, while existing users with persisted stopLive=true continue sending the viewed stop to GTT but cannot turn that disclosure off. The manual updateSchedulesNow() remap retry also becomes unreachable despite remaining supported. Decouple these direct-GTT controls from mirror availability before disabling the mirrors.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant