Repository navigation
Configure no timetable mirrors while GTT blocks CI runners - #23
Conversation
GTT's static-export host refuses connections from GitHub-hosted runners, so the timetable pipeline cannot build there and the workflow is disabled. With no mirror configured, devices make no mirror requests: freshness comes with app releases and rotated trip IDs use the direct GTT identity remap. The GTT notice now says so instead of naming unused hosts.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17945ca99d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * re-enable, publish packages from a host that can reach GTT and list the mirrors here, e.g. | ||
| * `{ base: 'https://avoid-quest.github.io/maps/gtt/', layout: 'tree' }`. | ||
| */ | ||
| export const TIMETABLE_MIRRORS: readonly TimetableMirror[] = []; |
There was a problem hiding this comment.
Keep direct-GTT controls available without timetable mirrors
On Android, emptying this list makes ScheduleStatus.updateSupported false, but StopBoardPanel.tsx:47–54 gates the entire settings section on that flag, including the per-stop live-data switch, Wi-Fi preference and manual remap refresh. Repository-wide search confirms these controls have no other UI entry point. Consequently, new users cannot enable per-stop predictions, while existing users with persisted stopLive=true continue sending the viewed stop to GTT but cannot turn that disclosure off. The manual updateSchedulesNow() remap retry also becomes unreachable despite remaining supported. Decouple these direct-GTT controls from mirror availability before disabling the mirrors.
Useful? React with 👍 / 👎.
Summary
The optional timetable freshness layer cannot run in GitHub Actions:
www.gtt.to.itrefuses TCP connections from GitHub-hosted runners. With no mirror configured, phones make no mirror requests (no IP exposure for nothing). Live boards are unaffected: the bundled package, the direct GTT identity remap and GTT realtime do not depend on mirrors. "Aggiorna orari" still retries the remap. The pipeline and workflow stay in the repo (workflow disabled) for a future host that can reach GTT.Evidence
URLError: <urlopen error timed out>; the same URL answered200in 59 ms from an Italian connection.bun run verify→ typecheck, lint, 434 tests;updateSupportedis false with an empty list and no manifest request is made.Merge Danger
Door: two-way
Re-adding the mirror entries restores the previous behaviour.
Blast Radius: transit-data
Only the optional manifest/package refresh; boards and remap unchanged.
Summary by cubic
Disables the timetable mirror configuration because GTT's static-export host refuses connections from GitHub-hosted runners, and updates the in-app privacy notice accordingly.
Written for commit 17945ca. Summary will update on new commits.