refactor(httpin): remove the embedded manual trigger form - #446
Merged
KillerX merged 1 commit intoAug 14, 2026
Merged
Conversation
GET /trigger served a single hand-written HTML form out of the binary. It was not a UI for the service so much as a bookmark: one workflow, ExportAssetVX, with its watermark path and destinations hardcoded as defaults, submitting to https://temporal-trigger.lan.bcc.media by absolute URL. So it only ever worked from that one deployment, and only for that one export. The form and its route go, along with the go:embed. /trigger/:job — the endpoint it posted to — is untouched; that is what the FileCatalyst and watcher integrations call. This does not touch TriggerableWorkflows. The form never read /schemas or /trigger-dynamic, so the second registration list is still live; removing it is a separate change with an outward-facing API attached. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7/n of a stack. Base:
fix/heartbeat-polling-activities(#445).GET /triggerserved a single hand-written HTML form out of the binary. It was not a UI for the service so much as a bookmark: one workflow,ExportAssetVX, with its watermark path and destinations hardcoded as defaults, submitting tohttps://temporal-trigger.lan.bcc.mediaby absolute URL — so it only ever worked from that one deployment, and only for that one export.The form and its route go, along with the
go:embed./trigger/:job— the endpoint it posted to — is untouched; that is what the FileCatalyst and watcher integrations call.This does not touch
TriggerableWorkflows. The form never read/schemasor/trigger-dynamic, so the second hand-maintained registration list is still live. See the PR discussion — removing it is a separate change with an outward-facing API attached.🤖 Generated with Claude Code