Skip to content

Dismiss approvals when content changes - #287

Open
seanprashad wants to merge 13 commits into
block:mainfrom
seanprashad:seanprashad/versioned-approvals
Open

seanprashad wants to merge 13 commits into
block:mainfrom
seanprashad:seanprashad/versioned-approvals

Conversation

@seanprashad

@seanprashad seanprashad commented Oct 29, 2026 •

Copy link
Copy Markdown

What changed and why

Reset active reviews to Pending when Markdown changes. Keep earlier decisions with the version reviewed, and reject stale submissions and retries. Human and agent decisions remain distinct.

Reset approvals by default. Authors can turn this off in Manage reviewers; changes save automatically. When off, completed reviews stay on the version reviewed.

Migration: existing active reviews need fresh decisions. Withdrawn requests and history remain. API clients must send the current request generation.

Reviews cover Markdown only, excluding titles, tags, attachments, linked or embedded content, and child plans.

How to try it

With reset enabled, approve a document, then edit its body. Reviews return to Pending; earlier decisions stay in activity.

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
@seanprashad seanprashad changed the title Bind approvals to current content and review cycles Bind approvals to content versions and reset reviews by default Oct 29, 2026
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
@seanprashad seanprashad changed the title Bind approvals to content versions and reset reviews by default Dismiss approvals when content changes Oct 29, 2026
@seanprashad
seanprashad marked this pull request as ready for review October 29, 2026 19:23
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant