Repository navigation
Make approval resets configurable - #289
Closed
seanprashad wants to merge 7 commits into
Closed
seanprashad wants to merge 7 commits into
seanprashad wants to merge 7 commits into
Conversation
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #287. Review the settings change only. The shared base will leave this diff after #287 merges.
What changed and why
Add a default-on “Reset approvals when content changes” option in Manage reviewers. When off, completed reviews stay completed after edits and show the version reviewed. Save automatically with a brief checkmark.
Evidence
Browser checks cover both themes, rapid toggles, and rejected or lost save responses.
How to try it
Open Manage reviewers, turn the option off, approve, and edit. The review stays completed on its original version. Turn the option on and edit again to reset it.
Testing
Six focused browser cases passed. RuboCop passed.
Generated with Codex