Repository navigation
Submit login-dependent client operations eagerly - #130
Merged
Stephen Belanger (Qard) merged 1 commit intoOct 28, 2026
Merged
Stephen Belanger (Qard) merged 1 commit into
Stephen Belanger (Qard) merged 1 commit into
Conversation
Stephen Belanger (Qard)
merged commit Oct 28, 2026
2b61019
into
refactor/eager-dataset-operations
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login-dependent client calls previously waited until their futures were polled, so an unobserved login wait or resource-builder request was absent from task admission and shutdown. Make wait_for_login, span_builder, and dataset_builder submit immediately to the selected runtime and return Completion tokens. Existing .await call sites still retrieve their eventual values.
Stacked on #129. Experiment operations and client span updates remain subsequent layers: trace-producing operations need to preserve their accepted delivery obligation while registration completes and shutdown closes public write admission.
Validation: 319 unit/integration tests and 9 doctests passed, with existing ignored tests unchanged. Strict all-target/all-feature Clippy, rustdoc, formatting, and diff checks passed. New consumer tests cover synchronous issuance with cross-executor observation, shutdown with unobserved login waits/builders, bounded admission after observer drop, immediate skipped-login rejection, and stopped explicit runtimes despite cached login state.