Repository navigation
Admit experiment events before resolving registration - #131
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Stephen Belanger (Qard) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment events previously registered first and queued their trace later, only after the caller polled the async method. A shutdown between those steps could close delivery admission before the event reached the queue. Make Experiment.log admit its write immediately and resolve registration during bounded delivery preparation; its Completion returns the row ID after full batch delivery. Experiment.flush now captures a cutoff immediately and returns the ordinary flush report token.
Stacked on #130. Other experiment methods and client span updates remain subsequent layers.
Validation: 327 unit/integration tests and 9 doctests passed; existing ignored tests unchanged. Strict all-target/all-feature Clippy, rustdoc, formatting, and diff checks passed. New regressions cover plain-thread unobserved progress after owner drop, shutdown before first poll, terminal registration failure and fresh retry, both admission limits without extra writes/registration, deferred-registration timeout, reentrant command cleanup, and stopped runtimes holding the last queue producer.