Repository navigation
Separate evaluation reporting and route CLI output through run adapters - #149
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Stephen Belanger (Qard) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluation requests now own their output adapter. A public fallible
EvalReporterseparates terminal, JSONL and CLI SSE presentation from case execution and recording. Local/custom reporters require neither serialization norSync; JSONL adds serialization only when selected.The first reporter error disables that reporter for the run while computation and recording continue. Completion returns a typed reporting stage/index and preserves the computed summary. Source and reporting errors survive together, dropped observers do not cancel reporting, and output failures do not poison client shutdown.
summary_to_valuenow returns serialization errors instead of a null placeholder.BtEvalRunnerselects reporters and submits through the canonical local/recorded entry point. Both local environment flags avoid creating a client, list/filter modes skip execution, and JSONL/SSE replace terminal progress. SSE preserves the existing start/summary/error event format and reports write/flush failures.Stacked on #147 (
refactor/eval-dataset-recording), completing the reporting portion of the original evaluation stage. Remaining CLI completion/lifecycle consolidation belongs to release preparation. Planning notes remain local.Validation: