Repository navigation
Make CLI evaluations eager and join accepted session work - #150
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Stephen Belanger (Qard) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI evaluations previously started only when their futures were polled, so dropping an observer skipped work and
finish()could not join unobserved submissions.BtEvalRunner::evalandfinishnow return eager completion tokens. Runs execute in call order, and finish joins accepted computation, recording, output and token publication before closing SSE and releasing session ownership.CLI and canonical evaluation entry points share the same single-response submission helpers and executor. Recorded work acquires scoped write authority at issuance, allowing already-admitted queued runs to finish after client shutdown starts. Local sessions own one runtime; supplied clients provide their fixed binding. Per-run CLI runtime overrides are rejected, and finishing does not close a supplied client.
Terminate-on-failure retains typed case/partial run outcomes and skips later queued sources. An ordered failure cutoff preserves work accepted before a later issuance rejection. Non-terminating mode keeps its existing continue-and-report-status behavior. Live ordering state retains no completed outcomes, full admission still leaves finish control capacity, and panic/runtime loss releases the ordering guard. A narrow internal finalization hook releases that guard after response publication, including cancellation races. Removed the redundant lazy
run_allhelper and moved adapter tests to a separate file.Stacked on #149 (
refactor/eval-reporting), continuing the original release-preparation stage. Constructor/API consolidation, dependency/MSRV resolution and packaging remain subsequent work. Planning notes remain local.Validation: