feat(code): add guided-manual-qa skill (ISS-11436) - #205
Merged
Merged
Conversation
Port the guided-manual-qa skill into the code plugin as code:guided-manual-qa. It derives and runs an interactive, evidence-recorded manual QA session: exact-head E2E coverage mapping, worktree-owned environment and persistence proof, a durable QA record, per-checkpoint oracle proof, and PASS/FAIL/BLOCKED human checkpoints. The interactive browser launcher is ported to TypeScript under tools/guided-manual-qa with vitest coverage, bundled to scripts/dist/launch-interactive-browser.mjs. Playwright is still resolved from the repository under test. Extract the duplicated runWhenMain helper and esbuild driver into tools/shared so design-inventory, code-review-cost and guided-manual-qa share one copy, and run all three toolchains in a CI matrix. Rebuilt bundles differ only in the inlined helper's source comment; design-inventory no longer emits the unused cli.mjs bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the
guided-manual-qaskill into thecodeplugin ascode:guided-manual-qa(ISS-11436).The skill derives and runs an interactive, evidence-recorded manual QA session for a change, ticket, branch, or PR:
PASS/FAIL/BLOCKEDone checkpoint at a timePlacement
plugins/code/skills/guided-manual-qa/:SKILL.mdplusreferences/(plan methodology, browser-state fixtures, QA record template).codeis the hub for coding-workflow skills and already owns the adjacent validation skills.agents/openai.yaml, replaced the$CODEX_HOMEscript path with${CLAUDE_SKILL_DIR}in SKILL.md (the only file where it is substituted), and replaced the Codex state directory with a harness-neutral user-level QA record location.Browser launcher ported to TypeScript
Per the repo's TS-only policy for new tool scripts, the Codex
.cjslauncher is rewritten astools/guided-manual-qa/src/launch-interactive-browser.tswith a 40-case vitest suite, bundled toskills/guided-manual-qa/scripts/dist/launch-interactive-browser.mjs. Behavior is preserved: Playwright resolves from the repository under test (never bundled), non-HTTP(S) URLs and non-string fixture values are rejected, private auth state is merged without mutation, the--ready-selectorgate and settled origin/path/Clerk-handshake check run before readiness, and only key names are printed.Shared toolchain helpers
runWhenMainwas already duplicated betweendesign-inventoryandcode-review-cost, and theirbuild.mjsfiles were near copies. Instead of a third copy, both now live intools/shared/(cli.ts,build-bundles.mjs), and all three packages import them by relative path. The CI TypeScript job becomes a matrix over all three toolchains (code-review-costpreviously had no CI). The check for design-inventory keeps its name,TypeScript (design-inventory).Rebuilt bundles differ only in the inlined helper's source-path comment.
design-inventoryno longer emits the unusedcli.mjsbundle.Versions
code1.14.11 -> 1.15.0 (new skill)code-review3.10.1 -> 3.10.2 (rebuiltcost-report.mjs, comment-only diff)Testing
npm run typecheckandnpm testpass for all three toolchains (guided-manual-qa 40, design-inventory 393, code-review-cost 43); bundles rebuilt.uv run ruff check .clean,uv run pyright0 errors,uv run pytest plugins/2175 passed.--helpworks, and the missing-Playwright path fails with the expected error.