Repository navigation
chore(ci): container-release v1.51.0 with issues: write - #104
Conversation
Moves the reusable workflow pin from v1.46.0 to v1.51.0 and grants the calling job issues: write: v1.51.0's alert job declares no permissions and inherits this token, so without the grant a failed scheduled run only warns. Nested job permissions and inputs are unchanged between the two; 1.50.0's version-label check compares only a label naming one of this repo's releases, which the release PR keeps current (a390). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
| jobs: | ||
| container: | ||
| uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.46.0 | ||
| uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.51.0 |
There was a problem hiding this comment.
MEDIUM (Test Coverage): This update enables new release and scheduled-failure behavior through the reusable workflow, but adds no test coverage for the integration. In particular, there is no test that a failed scheduled rebuild opens an issue or that promotion rejects an image whose version label does not match the repository release.
Suggestion: Add integration coverage for the reusable-workflow behaviors this update relies on: verify that a scheduled rebuild failure files an issue and that promotion rejects a mismatched version label while accepting a matching one.
Evidence:
uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.51.0
permissions:
contents: read
issues: write # the alert job files a failed schedule as an issue
pull-requests: read
There was a problem hiding this comment.
Not a bug: both behaviours live in the reusable workflow and are tested where they are implemented, not in each caller.
constitution v1.51.0 covers the failed-schedule alert in tests/test_release_alert.py. It covers the version-label refusal in tests/test_container_release.py: test_a_release_labelled_another_version_is_refused_before_any_tag_moves, test_a_stale_label_is_refused_however_it_is_spelled and test_the_oci_version_label_stands_in_for_a_missing_version. This PR changes only the pin and the token grant. This PR's own run exercises both: container / build → gates → mark gated, with alert skipped on a non-schedule event.
Batch 1 of the container-release caller migration (a390), the same change as the merged pilot crunchtools/rhel10-bootc-server#63. Two changes to the calling job, plus a CHANGELOG Unreleased line:
container-release.ymlfrom v1.46.0 to v1.51.0.issues: write. v1.51.0'salertjob declares no permissions and inherits this token. With the grant, a failed scheduled run opens (or comments on) one issue and the next passing run closes it. Without it, the run only warns.What changes between v1.46.0 and v1.51.0 for this repo:
with:block is valid as is.v*promote refuses an image whoseversionlabel names a different release of this repo. This Containerfile sets its ownversionlabel, and every recent tag sits on achore: releasePR that moved it, so the label matched each tag. The release PR has to keep moving that label; a tag on a feature merge would now be refused before anything is signed.free-disk, sogatesmoves to the org's own runners when the variables are set:CACHED_RUNNER_LABELon a same-repository pull request,UNCACHED_RUNNER_LABELon push, schedule, tag or manual run.build/mark/promotestay onubuntu-latestin this public repo.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb