Skip to content

chore(ci): container-release v1.51.0 with issues: write - #104

Merged
fatherlinux merged 1 commit into
mainfrom
chore/constitution-1.51.0
Nov 18, 2026
Merged

fatherlinux merged 1 commit into
mainfrom
chore/constitution-1.51.0

Conversation

@fatherlinux

@fatherlinux fatherlinux commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Batch 1 of the container-release caller migration (a390), the same change as the merged pilot crunchtools/rhel10-bootc-server#63. Two changes to the calling job, plus a CHANGELOG Unreleased line:

  • Pin container-release.yml from v1.46.0 to v1.51.0.
  • Grant issues: write. v1.51.0's alert job declares no permissions and inherits this token. With the grant, a failed scheduled run opens (or comments on) one issue and the next passing run closes it. Without it, the run only warns.

What changes between v1.46.0 and v1.51.0 for this repo:

  • Nested job permissions and inputs are the same, so the existing with: block is valid as is.
  • 1.50.0: a v* promote refuses an image whose version label names a different release of this repo. This Containerfile sets its own version label, and every recent tag sits on a chore: release PR that moved it, so the label matched each tag. The release PR has to keep moving that label; a tag on a feature merge would now be refused before anything is signed.
  • 1.47.0/1.48.0: runner selection. This repo doesn't set free-disk, so gates moves to the org's own runners when the variables are set: CACHED_RUNNER_LABEL on a same-repository pull request, UNCACHED_RUNNER_LABEL on push, schedule, tag or manual run. build/mark/promote stay on ubuntu-latest in this public repo.

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb

Moves the reusable workflow pin from v1.46.0 to v1.51.0 and grants the
calling job issues: write: v1.51.0's alert job declares no permissions and
inherits this token, so without the grant a failed scheduled run only warns.
Nested job permissions and inputs are unchanged between the two; 1.50.0's
version-label check compares only a label naming one of this repo's
releases, which the release PR keeps current (a390).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found 1 issues (1 medium)

Full review.

jobs:
container:
uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.46.0
uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.51.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEDIUM (Test Coverage): This update enables new release and scheduled-failure behavior through the reusable workflow, but adds no test coverage for the integration. In particular, there is no test that a failed scheduled rebuild opens an issue or that promotion rejects an image whose version label does not match the repository release.

Suggestion: Add integration coverage for the reusable-workflow behaviors this update relies on: verify that a scheduled rebuild failure files an issue and that promotion rejects a mismatched version label while accepting a matching one.

Evidence:

uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.51.0
permissions:
  contents: read
  issues: write   # the alert job files a failed schedule as an issue
  pull-requests: read

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug: both behaviours live in the reusable workflow and are tested where they are implemented, not in each caller.

constitution v1.51.0 covers the failed-schedule alert in tests/test_release_alert.py. It covers the version-label refusal in tests/test_container_release.py: test_a_release_labelled_another_version_is_refused_before_any_tag_moves, test_a_stale_label_is_refused_however_it_is_spelled and test_the_oci_version_label_stands_in_for_a_missing_version. This PR changes only the pin and the token grant. This PR's own run exercises both: container / build → gates → mark gated, with alert skipped on a non-schedule event.

@fatherlinux
fatherlinux merged commit 11e5085 into main Nov 18, 2026
21 of 22 checks passed
@fatherlinux
fatherlinux deleted the chore/constitution-1.51.0 branch November 18, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant