Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ permissions: {}

jobs:
container:
uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.46.0
uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.51.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEDIUM (Test Coverage): This update enables new release and scheduled-failure behavior through the reusable workflow, but adds no test coverage for the integration. In particular, there is no test that a failed scheduled rebuild opens an issue or that promotion rejects an image whose version label does not match the repository release.

Suggestion: Add integration coverage for the reusable-workflow behaviors this update relies on: verify that a scheduled rebuild failure files an issue and that promotion rejects a mismatched version label while accepting a matching one.

Evidence:

uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.51.0
permissions:
  contents: read
  issues: write   # the alert job files a failed schedule as an issue
  pull-requests: read

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug: both behaviours live in the reusable workflow and are tested where they are implemented, not in each caller.

constitution v1.51.0 covers the failed-schedule alert in tests/test_release_alert.py. It covers the version-label refusal in tests/test_container_release.py: test_a_release_labelled_another_version_is_refused_before_any_tag_moves, test_a_stale_label_is_refused_however_it_is_spelled and test_the_oci_version_label_stands_in_for_a_missing_version. This PR changes only the pin and the token grant. This PR's own run exercises both: container / build → gates → mark gated, with alert skipped on a non-schedule event.

permissions:
contents: read
issues: write # the alert job files a failed schedule as an issue
pull-requests: read
with:
image: quay.io/crunchtools/mcp-github
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ All notable changes to this project are documented here. The format follows

## [Unreleased]

### Changed
- The container release runs constitution v1.51.0's `container-release.yml`
(was v1.46.0) and grants it `issues: write`, so a failed scheduled rebuild
opens an issue instead of only warning. A `v*` promote now also refuses an
image whose `version` label names a different release of this repo, so the
release PR must keep moving the Containerfile label along with the other
version strings.

## [2.1.3] - 2026-11-17

### Fixed
Expand Down
Loading