Repository navigation
chore(ci): container-release v1.51.0 with issues: write #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MEDIUM (Test Coverage): This update enables new release and scheduled-failure behavior through the reusable workflow, but adds no test coverage for the integration. In particular, there is no test that a failed scheduled rebuild opens an issue or that promotion rejects an image whose version label does not match the repository release.
Suggestion: Add integration coverage for the reusable-workflow behaviors this update relies on: verify that a scheduled rebuild failure files an issue and that promotion rejects a mismatched version label while accepting a matching one.
Evidence:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bug: both behaviours live in the reusable workflow and are tested where they are implemented, not in each caller.
constitution v1.51.0 covers the failed-schedule alert in
tests/test_release_alert.py. It covers the version-label refusal intests/test_container_release.py:test_a_release_labelled_another_version_is_refused_before_any_tag_moves,test_a_stale_label_is_refused_however_it_is_spelledandtest_the_oci_version_label_stands_in_for_a_missing_version. This PR changes only the pin and the token grant. This PR's own run exercises both:container / build→gates→mark gated, withalertskipped on a non-schedule event.