Repository navigation
chore: float the sdlc gates on quay.io/crunchtools/sdlc - #35
Merged
Merged
Conversation
Converted by python-sdlc's scripts/convert_repo.py. The hooks and the `sdlc ci` job run .sdlc/bin/sdlc, which takes its launcher from quay.io/crunchtools/sdlc:latest, so nothing in this repo pins a python-sdlc release and no version-bump pull request follows this one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fatherlinux
enabled auto-merge (squash)
November 17, 2026 22:32
| *) refuse ;; | ||
| esac | ||
|
|
||
| dir=$(mktemp -d) || exit 2 |
There was a problem hiding this comment.
LOW (General Review): If creating the temporary directory fails, the wrapper exits with status 2 but provides no diagnostic. This makes an environmental failure harder to distinguish from other gate startup failures.
Suggestion: Print a brief error to stderr before exiting, such as sdlc: GATE CANNOT RUN: could not create temporary directory.
Evidence:
dir=$(mktemp -d) || exit 2
Member
Author
There was a problem hiding this comment.
Not a bug: .sdlc/bin/sdlc is the shared floating bootstrap, byte-identical in every repo and pinned by sha256 in constitution v1.46.0. Pulling sdlc:latest on each run is the design (python-sdlc 0.9.0).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jf39CzcsfQWLaZQnLK
There was a problem hiding this comment.
Gatehouse found no issues.
Reviewed 1 commit since 4ddd0ef (incremental).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last fleet-wide PR wave: this repo's gates move to the floating sdlc, so what they run changes when the image does and no pull request has to bump a pin.
What changed
.sdlc/bin/sdlc(new, executable): python-sdlc'sbin/sdlc-bootstrap. It asksquay.io/crunchtools/sdlcfor its launcher and runs it. It names no release, so nothing ever bumps it..pre-commit-config.yaml: the rev-pinned python-sdlc hooks (or the standalone Gourmand and Gatehouse hooks) become two local hooks running.sdlc/bin/sdlc commitand.sdlc/bin/sdlc push. Other hooks are kept..github/workflows/: thesdlc cijob runs.sdlc/bin/sdlc ciwithSDLC_IMAGE: ${{ vars.SDLC_IMAGE }}. Its name, and so the required check, is unchanged. Workflows the stub does not cover are kept;quay.io/crunchtools/python-sdlcbecomesquay.io/crunchtools/sdlc..specify/is not touched.How to roll back
SDLC_IMAGEto the last good release (X.Y.Z). CI uses it on its next run, with no pull request; the organization variable does the same fleet-wide. Locally,SDLC_IMAGE=X.Y.Z git push.git revertits squash commit on the default branch. That restores the pinned hooks and workflows exactly as they were.It merges itself (squash) when its required checks pass. Opened by python-sdlc's
scripts/fleet_wave.py; a re-run of the wave reuses the branchchore/sdlc-floatingand this pull request.