Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# The repo's own checks, from quay.io/crunchtools/sdlc -- the same image, the
# same launcher and the same commands the laptop's hooks run, so a green push
# predicts a green CI (constitution XII). Nothing here pins a release: the
# image prints its own launcher, and both float on :latest.
#
# The variable SDLC_IMAGE -- a repository's, or the organization's for the
# whole fleet -- picks other tooling: `main` for what has merged to python-sdlc
# and not been released, or a release such as `0.9.0` to hold one back. A
# variable, which only an admin sets, rather than a line a pull request could
# change in passing.
#
# Gourmand runs as its own job, not inside `sdlc ci`: XII has CI run push's
# checks except Gourmand and Gatehouse, which run through their own workflows
# (Gatehouse: gatehouse.yml).
#
# The job NAME `sdlc ci` is the required check in the org ruleset "Python SDLC
# gates", and the Gourmand job keeps the name its own workflow gave it. Renaming
# a job stops it gating, silently.
#
# python-sdlc's examples/ci.yml, written by scripts/convert_repo.py. Copy it
# unchanged.

name: CI

on:
push:
branches: [main, master]
pull_request:
workflow_dispatch:

permissions:
contents: read

jobs:
sdlc:
name: sdlc ci
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

# .sdlc/bin/sdlc is python-sdlc's bin/sdlc-bootstrap: it asks the image
# for its launcher and runs it, as the hooks do.
- name: sdlc ci
env:
SDLC_IMAGE: ${{ vars.SDLC_IMAGE }}
run: .sdlc/bin/sdlc ci

gourmand:
name: Code Quality (Gourmand)
uses: crunchtools/gatehouse/.github/workflows/gourmand.yml@v0
2 changes: 1 addition & 1 deletion .github/workflows/constitution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ permissions:
jobs:
constitution:
name: Constitution
uses: crunchtools/constitution/.github/workflows/validate.yml@v1.41.0
uses: crunchtools/constitution/.github/workflows/validate.yml@v1.46.0
2 changes: 1 addition & 1 deletion .github/workflows/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ permissions: {}

jobs:
container:
uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.41.0
uses: crunchtools/constitution/.github/workflows/container-release.yml@v1.46.0
permissions:
contents: read
pull-requests: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependabot-automerge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ permissions:
jobs:
automerge:
name: Dependabot
uses: crunchtools/constitution/.github/workflows/dependabot-automerge.yml@v1.41.0
uses: crunchtools/constitution/.github/workflows/dependabot-automerge.yml@v1.46.0
36 changes: 24 additions & 12 deletions .github/workflows/gatehouse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,18 @@
# Three jobs with DIFFERENT authority:
# • guard — a real blocking gate. Mark it a REQUIRED status check so a PR
# that tampers with your workflow files is rejected.
# • review — ADVISORY. It posts findings as PR comments and always passes;
# do NOT mark it required. An LLM reviewer is non-deterministic,
# • review — ADVISORY. It posts findings as PR comments and no finding
# fails it; it fails only when the review did not happen:
# fewer than half of the agents finished (provider down,
# key refused), or the reviewer could not run at all. Do
# NOT mark it required. An LLM reviewer is non-deterministic,
# so it must never hold merge authority. (Opt into blocking with
# `blocking: true` below only if you accept that tradeoff — and
# even then, keep it out of branch protection.)
# • triage — deterministic. Fails while any finding has no reply
# (`fixed in <sha>` or `not a bug: <reason>`). Safe to mark
# • triage — deterministic. Fails while any finding has no answer
# (`fixed in <sha>`, `not a bug: <reason>` or
# `deferred: <open issue URL>`), or while the
# last review did not finish. Safe to mark
# REQUIRED: it never judges code, only whether a human answered.

name: Gatehouse
Expand All @@ -28,7 +33,7 @@ on:
pull_request_target:
types: [opened, synchronize, reopened]
# A reply rings the doorbell: this run's own checks do not count toward
# branch rules, so examples/gatehouse-retriage.yml answers it by re-running
# branch rules, so gatehouse-retriage.yml answers it by re-running
# triage inside the pull_request_target run. Add that file too.
pull_request_review_comment:
types: [created, edited, deleted]
Expand All @@ -37,7 +42,8 @@ permissions: {} # default-deny; each job grants only what it needs

jobs:
# ── 1) Protect the workflow files themselves ────────────────────────────────
# Rejects PRs from forks that touch .github/workflows/. Safe under
# Rejects PRs from forks that touch .github/workflows/ or .sdlc/ (the
# launcher the required `sdlc ci` check runs). Safe under
# pull_request_target because it only reads the changed-file LIST via the
# API — it never checks out or runs your code. And because pull_request_target
# runs the BASE version of this file, a PR can't edit this job to disable it.
Expand Down Expand Up @@ -66,11 +72,11 @@ jobs:
echo "Head branch is in $GITHUB_REPOSITORY; allowing."; exit 0
fi
# Both sides of a rename: `gh pr diff --name-only` lists only the new
# path, so a fork could move a workflow out of .github/workflows/ unseen.
# path, so a fork could move a file out of .github/workflows/ or .sdlc/ unseen.
changed="$(gh api --paginate "repos/$GITHUB_REPOSITORY/pulls/$PR/files" \
--jq '.[] | .filename, (.previous_filename // empty)')"
if echo "$changed" | grep -qE '^\.github/workflows/'; then
echo "::error::PR modifies .github/workflows/ — not accepted from external contributors."
if echo "$changed" | grep -qE '^(\.github/workflows|\.sdlc)/'; then
echo "::error::PR modifies .github/workflows/ or .sdlc/ — not accepted from external contributors."
# Explain once, on the PR event; replies re-run the check, not the comment.
if [ "$EVENT" = "pull_request_target" ]; then
gh pr comment "$PR" --repo "$GITHUB_REPOSITORY" --body \
Expand All @@ -82,7 +88,8 @@ jobs:

# ── 2) Review the PR diff (no checkout, BYO key) ────────────────────────────
# The reviewer is maintained centrally in gatehouse's reusable workflow and the
# pinned container — so security fixes reach you without copying logic around.
# container it names, called at the major tag — so a fix reaches you with no
# change to this file.
# Scope OPENROUTER_API_KEY to this reusable workflow so only it can read the key.
review:
name: Gatehouse review
Expand All @@ -91,7 +98,7 @@ jobs:
contents: read
pull-requests: write
uses: crunchtools/gatehouse/.github/workflows/review.yml@v0
# Advisory by default — findings post as comments, the check always passes.
# Advisory by default — findings post as comments and never fail the check.
# Uncomment to let critical/high findings fail the check (still not required):
# with:
# blocking: true
Expand All @@ -100,7 +107,12 @@ jobs:

# ── 3) Every finding answered ──────────────────────────────────────────────
# Runs after the review on a push, and alone on a reply (review is skipped
# then, hence always()). Read-only, no secrets.
# then, hence always()). Read-only, no secrets. LOW findings need an answer
# only from Bug Hunter and Security Scan; other LOWs are advisory. To change
# which agents' LOWs are required (agent names, comma-separated), set the
# same list here and on the review job above, so the review posts them all:
# with:
# required_low_agents: "Bug Hunter,Security Scan,Test Coverage"
triage:
name: Gatehouse triage
needs: review
Expand Down
14 changes: 0 additions & 14 deletions .github/workflows/gourmand.yml

This file was deleted.

33 changes: 26 additions & 7 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,17 +1,36 @@
# Every check runs from quay.io/crunchtools/sdlc (constitution XII). Nothing
# here pins it: .sdlc/bin/sdlc asks the image for its own launcher and runs it,
# so the launcher, the image and every tool inside it float together on
# :latest -- for this laptop and, through .github/workflows/ci.yml, for CI.
# There is no `rev:` to bump, ever.
#
# SDLC_IMAGE=main git push judges this push with what has merged to
# python-sdlc and not been released. A repo opts
# its CI in with the repository variable SDLC_IMAGE.
#
# What each hook runs is configured in pyproject.toml ([tool.sdlc.commit],
# [tool.sdlc.push], [tool.sdlc.ci]) or, in a repo with no pyproject.toml,
# sdlc.toml. `.sdlc/bin/sdlc tiers` prints it.
#
# `default_install_hook_types` must name both: without pre-push, `pre-commit
# install` wires only the commit hook and every verdict silently stops running.

default_install_hook_types: [pre-commit, pre-push]

repos:
- repo: local
hooks:
- id: gourmand
name: Gourmand (AI slop detection)
entry: podman --events-backend=none run --rm --log-driver=none -v .:/src:Z -w /src quay.io/crunchtools/gourmand:latest check --full
- id: sdlc-commit
name: sdlc commit
entry: .sdlc/bin/sdlc commit
language: system
pass_filenames: false
always_run: true
stages: [pre-commit, pre-merge-commit]
- id: gatehouse
name: Gatehouse (AI code review, staged diff)
entry: bash -c 'git diff --cached | podman --events-backend=none run --rm --log-driver=none -i --env-file "$HOME/.config/mcp-env/gatehouse.env" -v .:/src:ro,Z -w /src quay.io/crunchtools/gatehouse:latest --stdin'
- id: sdlc-push
name: sdlc push
entry: .sdlc/bin/sdlc push
language: system
pass_filenames: false
always_run: true
stages: [pre-commit, pre-merge-commit]
stages: [pre-push]
62 changes: 62 additions & 0 deletions .sdlc/bin/sdlc
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
#!/bin/sh
# Run `sdlc` with no `rev:` to pin: get the launcher from the image, then run it.
#
# The launcher (bin/sdlc) ships inside quay.io/crunchtools/sdlc, so it floats
# with the image tag exactly as the tools in the image do: `:latest` by
# default, SDLC_IMAGE=main for what has merged and not been released, a
# release such as SDLC_IMAGE=0.9.0, or SDLC_IMAGE=@sha256:<digest>. Nothing
# else: this file runs whatever it pulls, so it pulls from that one repository.
# A seat trying a local build runs a python-sdlc clone's bin/sdlc instead. The
# image prints the launcher with its own ref written into it (`sdlc launcher
# <ref>`), so the launcher and the image it starts cannot disagree.
#
# A converted repo carries this file as .sdlc/bin/sdlc, and its hooks and its
# CI job run it (scripts/convert_repo.py writes it). Nothing in it names a
# release, so nothing ever bumps it, and the constitution pins its bytes. An
# `sdlc` RPM would install the same file as /usr/bin/sdlc.
#
# Host contract: podman and POSIX sh, nothing else. Never a pipe into `sh`: a
# failed pull would hand sh nothing, and nothing runs and exits 0. An image
# that cannot print its launcher is a 2 -- the gate could not run.

set -u

FLEET=quay.io/crunchtools/sdlc
refuse() {
printf 'sdlc: GATE CANNOT RUN: SDLC_IMAGE=%s is not main, latest, X.Y.Z or @sha256:<64 hex> of %s\n' \
"${SDLC_IMAGE:-}" "$FLEET" >&2
exit 2
}

# The value, with the repository named in full or not at all.
want=${SDLC_IMAGE:-latest}
case $want in
"$FLEET":*) want=${want#"$FLEET":} ;;
"$FLEET"@*) want=${want#"$FLEET"} ;;
esac
case $want in
main|latest) image=$FLEET:$want ;;
@sha256:*)
hex=${want#@sha256:}
case $hex in *[!0-9a-f]*) refuse ;; esac
[ "${#hex}" -eq 64 ] || refuse
image=$FLEET$want ;;
*[!0-9.]*|.*|*.|*..*|*.*.*.*) refuse ;;
*.*.*) image=$FLEET:$want ;;
*) refuse ;;
esac

dir=$(mktemp -d) || exit 2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW (General Review): If creating the temporary directory fails, the wrapper exits with status 2 but provides no diagnostic. This makes an environmental failure harder to distinguish from other gate startup failures.

Suggestion: Print a brief error to stderr before exiting, such as sdlc: GATE CANNOT RUN: could not create temporary directory.

Evidence:

dir=$(mktemp -d) || exit 2

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug: .sdlc/bin/sdlc is the shared floating bootstrap, byte-identical in every repo and pinned by sha256 in constitution v1.46.0. Pulling sdlc:latest on each run is the design (python-sdlc 0.9.0).

trap 'rm -rf "$dir"' EXIT
trap 'exit 2' HUP INT TERM

# --pull=newer: :latest moves, and a stale local copy is how a two-week-old
# reviewer once judged trentina. Offline, podman keeps the copy it has.
if ! podman --events-backend=none run --rm --log-driver=none --network=none \
--cap-drop=all --security-opt=no-new-privileges --pull=newer \
-- "$image" launcher "$image" > "$dir/sdlc" || [ ! -s "$dir/sdlc" ]; then
printf 'sdlc: GATE CANNOT RUN: %s could not print its launcher\n' "$image" >&2
exit 2
fi
# The launcher reads SDLC_IMAGE too; it gets the full reference checked here.
SDLC_IMAGE=$image sh "$dir/sdlc" "$@"
2 changes: 1 addition & 1 deletion .specify/memory/constitution.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
> **Ratified:** 2026-05-21
> **Amended:** 2026-11-03
> **Status:** Active
> **Inherits:** [crunchtools/constitution](https://github.com/crunchtools/constitution) v1.41.0
> **Inherits:** [crunchtools/constitution](https://github.com/crunchtools/constitution) v1.46.0
> **Profile:** Container Image

This file holds what is specific to postfix. The fleet rules and the Container
Expand Down
Loading