Skip to content

feat!: ci may not skip a push verdict - #19

Merged
fatherlinux merged 2 commits into
mainfrom
feature/ci-may-not-skip-a-verdict
Nov 5, 2026
Merged

fatherlinux merged 2 commits into
mainfrom
feature/ci-may-not-skip-a-verdict

Conversation

@fatherlinux

@fatherlinux fatherlinux commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

What

[tool.sdlc.ci] skip may no longer name a check the push tier renders a verdict with — mypy, pytest, semgrep, pip-audit, constitution, codeql. resolve() refuses the config and names what it objects to.

Why

Constitution XII: "CI runs push's checks except Gourmand and Gatehouse." Those two are CI_EXCLUDES, decided by this tool, not by a repo. Skipping any other verdict in the ci block alone leaves it on pre-push — a developer's machine, one --no-verify from gone — while the required sdlc ci reports green.

That is not hypothetical. 24 of the 33 repos converted under RT#1552 carried [tool.sdlc.ci] skip = ["codeql"], each with a comment claiming the CodeQL Action covered it. Checked against the rulesets:

repos
CodeQL Analysis is a required check 1 (trentina)
the Action runs on PRs but is advisory 21
CodeQL never runs on a pull request 2 — ashigaru has no CodeQL workflow; rotv's upload-sarif is gated on github.event_name != 'pull_request'

So in 23 of them the only place CodeQL could block was a hook I had been pushing past with --no-verify. I wrote those skips; this is the fix.

All 24 consumer repos have now dropped the skip and merged — 0 of 33 ci blocks skip a verdict. Turning CodeQL on found real findings in 4 of them straight away, including two credential exposures in rotv's scripts/get_google_token.py (an OAuth refresh token written world-readable, and all three credentials printed to stdout), both fixed.

Why this one goes second

0.4.0 (#22) had to land first, and not only for version ordering. #22 dropped all capabilities from the gate's own containers, and that broke CodeQL: the bundle's 25 precompiled .qlx files extract at mode 0600 owned by uid 1001, and root had been reading them purely on CAP_DAC_OVERRIDE. Without it, every query recompiled and codeql database analyze died with exit 100 — 355 seconds and an exit 2 instead of a verdict. #22 fixed it in the image (chown/chmod after extraction rather than handing the capability back, which also took codeql from 355s to 95s).

Merged the other way round, the 24 repos would have dropped their ci skip just in time for CodeQL to stop running everywhere. Worth stating plainly, because this PR's whole claim is that CodeQL can now block, and that claim depends on #22.

Where the refusal lands

sdlc_config() validates every block whichever command runs, so a repo that adds the skip back finds out on its next sdlc commit, not in CI — which matters, because in CI the skip is exactly what would have made it read green.

Still legal: skipping a check the repo added itself, and naming gourmand/gatehouse (which ci never runs anyway). A check that should run nowhere belongs out of [tool.sdlc.push], where the decision is visible in one place rather than as a difference between two tiers nobody reads side by side.

Verification

tests/test_plan.py: one case per verdict asserting the refusal, generated from DEFAULTS["push"] - CI_EXCLUDES so it grows by itself if a verdict is added; plus the two exclusions staying legal, a repo-added check still skippable, and the commit-time catch. The TRENTINA fixture carried the skip and no longer does. Full run against the rebased branch: all passed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Full review.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Reviewed 1 commit since b952ec3 (incremental).

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Reviewed 1 commit since 248c478 (incremental).

Constitution XII says CI runs push's checks except Gourmand and Gatehouse.
Those two are CI_EXCLUDES, decided here. Skipping any other verdict in the
`ci` block alone left it on pre-push -- a developer's machine, one
`--no-verify` from gone -- while the required `sdlc ci` reported green.

24 of the 33 repos converted under RT#1552 carried
`[tool.sdlc.ci] skip = ["codeql"]`, each justified by a comment saying the
CodeQL Action covered it. Against the rulesets: that check was required in 1,
advisory in 21, and never ran on a pull request in 2 -- ashigaru has no CodeQL
workflow at all, and rotv's upload-sarif step is gated on
`github.event_name != 'pull_request'`. So in 23 repos the only place CodeQL
could block was a hook I had been pushing past with --no-verify.

resolve() now refuses the config and names what it objects to. sdlc_config()
validates every block whichever command runs, so a repo that adds the skip
back finds out on its next `sdlc commit` rather than in CI -- where the skip
is exactly what would have made it read green. A check the repo added itself
may still be skipped in ci; a check that should run nowhere belongs out of
[tool.sdlc.push], where the decision sits in one place.

The TRENTINA fixture in tests/test_plan.py carried the skip and now does not;
six new refusal cases cover every verdict, plus the two that stay legal, a
repo-added check, and the commit-time catch.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6
Crunchtools 1's call, and the right one: 0.4.0 is ready now and this is
blocked behind 24 consumer repos dropping the ci codeql skip, so holding the
number here would park the fleet behind that. Rebases onto main once 0.4.0
merges.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6
@fatherlinux
fatherlinux force-pushed the feature/ci-may-not-skip-a-verdict branch from 2b24ade to 5cf69ce Compare November 5, 2026 02:06

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Full review.

@fatherlinux
fatherlinux enabled auto-merge (squash) November 5, 2026 02:07
@fatherlinux
fatherlinux merged commit 14d0ec7 into main Nov 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant