Repository navigation
fix: promote copies the tested digest, never a rewrap (RT#1550) - #43
Merged
Merged
Conversation
The promote job used plain skopeo copy for :main/:latest and the version tags. Without --all --preserve-digests a copy may rewrite the manifest, so a tag could resolve to bytes no gate tested; 35 repos pin this image. Every promotion now copies with both flags and reads the tag back, failing if it is not the tested digest. python-sdlc stays a listed custom-release repo; it now inherits constitution v1.39.1, whose validator checks exactly this. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jh5QhdxRuFKyWVev5h
| # manifest, and the read-back fails the job if the tag resolves to | ||
| # anything but the digest that was tested. | ||
| want=${REF#*@} | ||
| promote() { |
There was a problem hiding this comment.
LOW (General Review): The new promote helper takes only the destination tag as an argument but also depends on the ambient REF and QUAY variables. That hidden dependency makes the helper harder to understand and reuse independently.
Suggestion: Pass the source reference and destination repository explicitly to promote, or otherwise make its dependencies explicit in the helper's name or surrounding structure.
Evidence:
promote() {
skopeo copy --all --preserve-digests "docker://$REF" "docker://$QUAY:$1"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python-sdlc is one of two repos allowed its own release workflow (
container_release_custom), and constitution v1.39.1's validator holds those repos toskopeo copy --all --preserve-digests. The promote job used plainskopeo copy, which may rewrite a manifest, so:main/:latest/the version tags could resolve to bytes no gate tested. 35 repos pin this image.promotehelper:skopeo copy --all --preserve-digests, then a read-back that fails the job unless the tag resolves to the tested digest.Test plan
:main== the tested digest🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jh5QhdxRuFKyWVev5h