Skip to content

fix: promote copies the tested digest, never a rewrap (RT#1550) - #43

Merged
fatherlinux merged 1 commit into
mainfrom
fix/promote-preserve-digests
Nov 11, 2026
Merged

fatherlinux merged 1 commit into
mainfrom
fix/promote-preserve-digests

Conversation

@fatherlinux

Copy link
Copy Markdown
Member

Summary

python-sdlc is one of two repos allowed its own release workflow (container_release_custom), and constitution v1.39.1's validator holds those repos to skopeo copy --all --preserve-digests. The promote job used plain skopeo copy, which may rewrite a manifest, so :main/:latest/the version tags could resolve to bytes no gate tested. 35 repos pin this image.

  • One promote helper: skopeo copy --all --preserve-digests, then a read-back that fails the job unless the tag resolves to the tested digest.
  • Inherits constitution v1.39.1 (pins too); the validator passes.

Test plan

  • validator v1.39.1 PASS
  • CI green; the next main promotion shows :main == the tested digest

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jh5QhdxRuFKyWVev5h

The promote job used plain skopeo copy for :main/:latest and the version
tags. Without --all --preserve-digests a copy may rewrite the manifest,
so a tag could resolve to bytes no gate tested; 35 repos pin this image.
Every promotion now copies with both flags and reads the tag back,
failing if it is not the tested digest. python-sdlc stays a listed
custom-release repo; it now inherits constitution v1.39.1, whose
validator checks exactly this.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jh5QhdxRuFKyWVev5h

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found 1 issues (1 low)

Full review.

1 finding(s) dropped: their evidence is not in the diff.

1 of 8 agents served by google/gemini-3.1-flash-lite (primary unavailable).

# manifest, and the read-back fails the job if the tag resolves to
# anything but the digest that was tested.
want=${REF#*@}
promote() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW (General Review): The new promote helper takes only the destination tag as an argument but also depends on the ambient REF and QUAY variables. That hidden dependency makes the helper harder to understand and reuse independently.

Suggestion: Pass the source reference and destination repository explicitly to promote, or otherwise make its dependencies explicit in the helper's name or surrounding structure.

Evidence:

promote() {
  skopeo copy --all --preserve-digests "docker://$REF" "docker://$QUAY:$1"

@fatherlinux
fatherlinux merged commit b18600d into main Nov 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant