Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/constitution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ permissions:
jobs:
constitution:
name: Constitution
uses: crunchtools/constitution/.github/workflows/validate.yml@v1.35.0
uses: crunchtools/constitution/.github/workflows/validate.yml@v1.39.1
16 changes: 13 additions & 3 deletions .github/workflows/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,16 @@ jobs:
# registry, and 35 repos pin this image. Asked of whichever tag THIS
# run moves: a re-run of an old release tag must not demote `latest`
# any more than a re-dispatched old commit may demote `main`.
# Copy the tested digest, never a rewrap of it (constitution VII,
# RT#1550): --preserve-digests refuses a copy that would change the
# manifest, and the read-back fails the job if the tag resolves to
# anything but the digest that was tested.
want=${REF#*@}
promote() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW (General Review): The new promote helper takes only the destination tag as an argument but also depends on the ambient REF and QUAY variables. That hidden dependency makes the helper harder to understand and reuse independently.

Suggestion: Pass the source reference and destination repository explicitly to promote, or otherwise make its dependencies explicit in the helper's name or surrounding structure.

Evidence:

promote() {
  skopeo copy --all --preserve-digests "docker://$REF" "docker://$QUAY:$1"

skopeo copy --all --preserve-digests "docker://$REF" "docker://$QUAY:$1"
got=$(skopeo inspect --format '{{.Digest}}' "docker://$QUAY:$1")
[ "$got" = "$want" ] || { echo ":$1 resolves to $got, not the tested $want" >&2; exit 1; }
}
if [ -n "$floating" ]; then
current=$(skopeo inspect --format \
'{{ index .Labels "org.opencontainers.image.revision" }}' \
Expand All @@ -267,14 +277,14 @@ jobs:
exit 1
fi
fi
skopeo copy "docker://$REF" "docker://$QUAY:$floating"
promote "$floating"
fi
case "$GITHUB_REF" in
refs/tags/v*)
version=${GITHUB_REF#refs/tags/v}
skopeo copy "docker://$REF" "docker://$QUAY:$version"
promote "$version"
# The minor tag so a consumer MAY track patches if it chooses to.
skopeo copy "docker://$REF" "docker://$QUAY:${version%.*}"
promote "${version%.*}"
echo "promoted $version"
;;
esac
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependabot-automerge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ permissions:
jobs:
automerge:
name: Dependabot
uses: crunchtools/constitution/.github/workflows/dependabot-automerge.yml@v1.35.0
uses: crunchtools/constitution/.github/workflows/dependabot-automerge.yml@v1.39.1
2 changes: 1 addition & 1 deletion .specify/memory/constitution.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
> **Ratified:** 2026-11-04
> **Amended:** 2026-11-04
> **Status:** Active
> **Inherits:** [crunchtools/constitution](https://github.com/crunchtools/constitution) v1.35.0
> **Inherits:** [crunchtools/constitution](https://github.com/crunchtools/constitution) v1.39.1
> **Profile:** Container Image

This is a manifest. It carries only what is unique to this repo; the fleet rules
Expand Down
Loading