Repository navigation
chore: release python-sdlc 0.9.0 - #63
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
A release opens no bump pull requests any more: converted repos float on sdlc:latest, and v0.9.0 bump PRs would conflict with the conversion PRs on .pre-commit-config.yaml. The job and scripts/bump_consumers.py go; the docs that described step 3 now describe the promote to :latest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
There was a problem hiding this comment.
Gatehouse found no issues.
Reviewed 1 commit since c208437 (incremental).
1 finding(s) dropped: their evidence is not in the diff.
…rse failures container-smoke is advisory unless [tool.sdlc.ci.container-smoke] gate = true: a finding prints FOUND SOMETHING, ADVISORY (record exit 5) and the command does not fail. Exit 0 passes whatever podman says of OOMKilled. hadolint's SC1072 on exec-form RUN is ignored by default, and a Containerfile it cannot parse is printed as ADVISORY and SKIPPED. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
… at 4ae89d0 A converted repo never meets GATE CANNOT RUN on its first run: skip-stacks for node, bootc and docs, and [tool.sdlc.ci] skip for the container checks when the Containerfile needs build secrets. examples/gatehouse.yml is gatehouse#150's, whose guard covers .sdlc/, and an older guard is upgraded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
There was a problem hiding this comment.
Gatehouse found 2 issues (1 critical, 1 high)
Reviewed 3 commits since 3b68e02 (incremental).
3 finding(s) dropped: their evidence is not in the diff.
| guard = jobs.get("guard") | ||
| if isinstance(guard, dict): | ||
| steps = [ | ||
| {k: v for k, v in step.items() if k != "run"} if isinstance(step, dict) else step |
There was a problem hiding this comment.
HIGH (Bug Hunter): This comparison removes the run field from every step in the guard, not just the guard script that the converter intends to refresh. As a result, a customized run command in another guard step is treated as equivalent to the canonical file, and --apply replaces it with the canonical version, silently discarding the customization.
Suggestion: Normalize only the specific guard script step whose change is intended to be accepted; preserve and compare run fields in all other steps.
Evidence:
steps = [
{k: v for k, v in step.items() if k != "run"} if isinstance(step, dict) else step
for step in guard.get("steps") or []
]
There was a problem hiding this comment.
Fixed in 873acac
same_gatehouse no longer ignores run. The guard's steps must either match the example exactly or be exactly the guard script from before gatehouse#150 (the three lines that PR changed, reverted). Any other difference in any step keeps the file. New test: a guard script with one added line is kept, not overwritten. All 11 fleet copies on this seat are still upgraded.
| # something, as it always has. | ||
| case "$_rs:$1:$2" in | ||
| 4:host-up:*|4:host-up-advisory:*|4:image-ro:containerfile-lint) ;; | ||
| 1:host-up-advisory:*) return 5 ;; |
There was a problem hiding this comment.
CRITICAL (Constitution): An ungated smoke check that finds something is converted to status 5 and then treated as non-failing. The command therefore succeeds despite a finding, contrary to the constitution's exit-code contract: 0 means the check found nothing and 1 means it found something.
Suggestion: Keep advisory presentation separate from the check's verdict: a smoke finding must retain a finding result and make the command exit 1, unless the constitution is amended to define a different contract.
Evidence:
1:host-up-advisory:*) return 5 ;;
4:*|5:*) return 1 ;;
There was a problem hiding this comment.
Not a bug: advisory smoke is the operator's decision for the conversion wave, and the finding is not reported as a pass.
The finding is never presented as clean. The run prints FOUND SOMETHING, ADVISORY: not gating together with how to make it gate, and the record carries exit 5, not 0. A smoke run that could not run is still a 2. The command's exit 0 means only that nothing gating failed. A repo opts into gating with gate = true in [tool.sdlc.ci.container-smoke], and the plan is to tighten repo by repo after the wave. This is flagged to the release owner for Exedore 2's re-review.
…fore gatehouse#150 Ignoring every guard step's run let a customized guard be overwritten. Now the guard's steps must be the example's, or exactly its script before #150; anything else keeps the file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
There was a problem hiding this comment.
Gatehouse found 3 issues (1 high, 1 medium, 1 low)
Reviewed 1 commit since 9fd9ae2 (incremental).
| before = [prior_guard(run) if isinstance(run, str) else run for run in new] | ||
| if old != before or old == new: | ||
| return False | ||
| jobs = dict(current["jobs"]) |
There was a problem hiding this comment.
HIGH (Bug Hunter): The legacy-guard check compares only each step’s run value, then replaces the entire guard steps list with the canonical list. A customized legacy guard step with the expected script but a different env, uses, with, or other step property therefore passes same_gatehouse and is overwritten during conversion, despite the stated behavior that other guard differences are kept.
Suggestion: Before replacing the steps, verify that current guard steps match canonical guard steps in every field except the run values recognized as pre-150. Only normalize the file when those non-run fields also match.
Evidence:
if old != before or old == new:
return False
jobs = dict(current["jobs"])
jobs["guard"] = {**jobs["guard"], "steps": canonical["jobs"]["guard"]["steps"]}
return {**current, "jobs": jobs} == canonical
There was a problem hiding this comment.
Fixed in 3b518d5
The steps list is no longer replaced. A step's run is rewritten only when it is exactly the pre-#150 script, and the whole document, including every other field of every step, must then equal the example. A step with its own env, uses or with keeps the file as it is.
| and snapshot(repo)[".github/workflows/gatehouse.yml"] == CUSTOM, | ||
| done.stderr, | ||
| ) | ||
| GUARD_CHANGED = OLD_GUARD.replace( |
There was a problem hiding this comment.
MEDIUM (Test Coverage): The new regression test checks preservation only when a guard's run script is customized. It does not cover other edits to a guard step, such as uses, with, or env. Those edits matter because the migration replaces the guard's entire steps list, so a non-run customization could be overwritten while the old run scripts still match.
Suggestion: Add a case that starts from OLD_GUARD, changes a non-run field on a guard step, and asserts conversion preserves the customized file.
Evidence:
GUARD_CHANGED = OLD_GUARD.replace(
'echo "No workflow files changed."', 'echo "No workflow files changed."\n make audit'
)
There was a problem hiding this comment.
Fixed in 3b518d5
Added "an older guard whose step has its own env is kept, not overwritten". It starts from the pre-#150 guard, adds an env entry to the guard step, and asserts the file is unchanged after --apply.
| included, keeps the file as it is. | ||
| """ | ||
|
|
||
| def guard_runs(doc: dict) -> list: |
There was a problem hiding this comment.
LOW (Consistency Check): guard_runs has no return type annotation, unlike the nearby helpers prior_guard (scripts/convert_repo.py:394, -> str) and same_gatehouse (scripts/convert_repo.py:401, -> bool). This makes the helper’s API less explicit than the surrounding functions.
Suggestion: Add a return type annotation that reflects the possible values returned for each step.
Evidence:
def guard_runs(doc: dict) -> list:
guard = (doc.get("jobs") or {}).get("guard")
steps = guard.get("steps") if isinstance(guard, dict) else None
return [s.get("run") if isinstance(s, dict) else None for s in steps or []]
There was a problem hiding this comment.
Fixed in 3b518d5
The guard_runs helper is gone. same_gatehouse now normalizes the steps inline, so there is no unannotated helper left.
… script Replacing the guard's whole step list could overwrite a step's own env or with. Now only that run is rewritten and the whole document is compared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
There was a problem hiding this comment.
Gatehouse found no issues.
Reviewed 1 commit since 873acac (incremental).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jf39CzcsfQWLaZQnLK
There was a problem hiding this comment.
Gatehouse found no issues.
Reviewed 2 commits since 3b518d5 (incremental).
Release 0.9.0. This moves the version strings in
IMAGE_TAG, the ContainerfileLABEL versionandpyproject.tomlfrom 0.8.0 to 0.9.0, and rolls the CHANGELOG's Unreleased section into[0.9.0] - 2026-11-17. It has the same shape as #61, the 0.8.0 release.What 0.9.0 carries (#62):
sdlc launcher <ref>).bin/sdlc-bootstrapis the file a converted repo carries as.sdlc/bin/sdlc.scripts/convert_repo.pyconverts a repo to the floating form.errorthreshold and ignores the fleet's deliberate conventions (DL3007, DL3041).0.9.0 is the first release that carries
launcher. Rolling back withSDLC_IMAGE=X.Y.Zworks only once a second release carries it too.Not tagged here; the release is created after merge.
🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb