Repository navigation
chore: release python-sdlc 0.9.0 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c208437
chore: release python-sdlc 0.9.0
3b68e02
chore: remove bump-consumers; repos float on sdlc:latest
d725992
fix(container): advisory smoke, OOM on exit 0, hadolint SC1072 and pa…
8494860
feat(convert): write skip-stacks and build-secret ci skips; gatehouse…
9fd9ae2
docs: advisory smoke, lint and converter changes in 0.9.0
873acac
fix(convert): upgrade a gatehouse guard only from the exact script be…
3b518d5
fix(convert): normalize only a guard run that is exactly the pre-#150…
16738d9
Merge main into chore/release-0.9.0
fatherlinux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 0.8.0 | ||
| 0.9.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRITICAL (Constitution): An ungated smoke check that finds something is converted to status 5 and then treated as non-failing. The command therefore succeeds despite a finding, contrary to the constitution's exit-code contract: 0 means the check found nothing and 1 means it found something.
Suggestion: Keep advisory presentation separate from the check's verdict: a smoke finding must retain a finding result and make the command exit 1, unless the constitution is amended to define a different contract.
Evidence:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bug: advisory smoke is the operator's decision for the conversion wave, and the finding is not reported as a pass.
The finding is never presented as clean. The run prints
FOUND SOMETHING, ADVISORY: not gatingtogether with how to make it gate, and the record carries exit 5, not 0. A smoke run that could not run is still a 2. The command's exit 0 means only that nothing gating failed. A repo opts into gating withgate = truein[tool.sdlc.ci.container-smoke], and the plan is to tighten repo by repo after the wave. This is flagged to the release owner for Exedore 2's re-review.