Skip to content

Simplify Maven build - #1894

Open
deluxe wants to merge 2 commits into
datafaker-net:mainfrom
deluxe:feature/maven
Open

Simplify Maven build#1894
deluxe wants to merge 2 commits into
datafaker-net:mainfrom
deluxe:feature/maven

Conversation

@deluxe

@deluxe deluxe commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Address #1893

@what-the-diff

what-the-diff Bot commented Jul 29, 2026

Copy link
Copy Markdown

PR Summary

  • Project Version Update
    The project version description has been updated from an older version (3.0.0-SNAPSHOT), which means the software is being prepared and streamlined for an upcoming release.

  • Simplification of Java Version Management
    The property names releaseJavaVersion and buildJavaVersion have been consolidated into a single java.version property. This makes it easier to manage the software's Java version, reducing complexity and potential confusion.

  • Elimination of Unnecessary Dependencies
    Unneeded Kotlin dependencies such as kotlin-stdlib-jdk8 and kotlin-test have been removed from the dependencies section. This cleans up the code, making it more streamlined and reducing the computing resources it requires.

  • Maven Compiler Plugin Configuration Improvement
    The Maven compiler plugin configuration, which helps build the project, has been adjusted to use the simplified java.version property, making for a more efficient build process.

  • Reference Update
    The sections <requireMavenVersion> and <requireJavaVersion> have been altered to reference the updated java.version property. This facilitates maintaining software version consistency, a crucial factor in functionality and compatibility.

  • Comment Clarity
    A related comment about attaching Javadoc for OSSRH compliance has been clarified. This eases understanding for anyone reading or using the code, fostering better collaboration.

@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.56%. Comparing base (4d4274a) to head (be422fe).
⚠️ Report is 2 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1894      +/-   ##
============================================
+ Coverage     92.45%   92.56%   +0.11%     
- Complexity     3569     3573       +4     
============================================
  Files           347      347              
  Lines          7052     7052              
  Branches        675      675              
============================================
+ Hits           6520     6528       +8     
+ Misses          369      365       -4     
+ Partials        163      159       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added this to the 3.0.0 milestone Jul 29, 2026
@bodiam

bodiam commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What's the propose of this PR, and what's with these commit messages. If you use an AI, please use one which isn't silly. Also, why is the upper bound of maven removed?

@deluxe

deluxe commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

What's the propose of this PR, and what's with these commit messages. If you use an AI, please use one which isn't silly. Also, why is the upper bound of maven removed?

Hi there. Sorry for the lack of explanations for the changes!

I do not use AI, those silly commit messages are 100% mine ^^. You must be talking in particular about "Let configuration breath": I did not mind about it since merge with squash would overwrite it. I can change it if needed.

The upper bound of maven isn't removed, the range definition is replaced with the simpler syntax: https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #1893 by simplifying the Maven build configuration: it consolidates Java build/release version properties and streamlines the Kotlin Maven plugin setup using the extensions mechanism.

Changes:

  • Replace releaseJavaVersion/buildJavaVersion with a single java.version property and use it for compiler release.
  • Simplify Kotlin Maven plugin configuration by switching to extensions=true and removing explicit executions/sourceDirs wiring.
  • Minor cleanup/formatting adjustments in pom.xml (comments, whitespace, property empty tag style).

Comment thread pom.xml
Comment thread pom.xml
Comment thread pom.xml
Comment thread pom.xml
@kingthorin

Copy link
Copy Markdown
Collaborator

Thanks @deluxe, appreciate you taking the time to answer copilot's review.

@deluxe

deluxe commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @deluxe, appreciate you taking the time to answer copilot's review.

It was a good opportunity to explain changes.
But I must say I am disappointed with Copilot review quality: 4 wrong comments out of 4! The only good part is the overview.

@deluxe

deluxe commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Hi everybody, I'm still alive!

I removed all the new line noise. And I closed threads not moving anymore to clear up the discussion (and the diff view).

Now, I still think one java version property is better than two.
And I still think that using the kotlin-maven-plugin extensions option is better than keeping 70 lines of configuration to do the same.

I'm curious about the opinion of the others contributors, but if @bodiam you're the one calling the shots and you don't want the PR to be merged, so be it.
Close it, or ask me to close it, and let's be done with it one way or another. It won't wake me at night either way but I'd like the PR not to linger anymore.

@kingthorin kingthorin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it still builds as intended this is fine to me.

I like simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants