Skip to content

Simplify Maven build #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deluxe wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −84
Open

Simplify Maven build #1894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c0cf9
Simplify java versionning
deluxe Jul 19, 2026
b503542
Replace Kotlin plugin manual configuration with extensions
deluxe Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 11 additions & 84 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@
<name>Datafaker</name>
<description>
This library is an improved fork of JavaFaker (as well as Ruby's stympy/faker gem and Perl's Data::Faker
library)
that generates fake data. It's useful when you're developing a new project and need some pretty data for
showcase.
library) that generates fake data.
It's useful when you're developing a new project and need some pretty data for showcase.
</description>
<url>https://www.datafaker.net</url>
<developers>
Expand Down Expand Up @@ -39,8 +38,7 @@
<jspecify.version>1.0.0</jspecify.version>
<error_prone.version>2.50.0</error_prone.version>

<releaseJavaVersion>17</releaseJavaVersion>
<buildJavaVersion>17</buildJavaVersion>
<java.version>17</java.version>

<central-publishing-maven-plugin.version>0.11.0</central-publishing-maven-plugin.version>
<maven-compiler-plugin.version>3.15.0</maven-compiler-plugin.version>
Expand All @@ -61,10 +59,10 @@
<javaparser.version>3.28.2</javaparser.version>
<snakeyaml.version>2.6</snakeyaml.version>
<spotless-maven-plugin.version>3.9.0</spotless-maven-plugin.version>
<!-- Empty means scan all, non empty value will be passed from CI -->
<spotless.ratchetFrom></spotless.ratchetFrom>
<!-- Run tests in Turkish to make sure that they don't depend on
locale. Turkish is a notoriously tricky locale. -->
<!-- Empty means scan all, non-empty value will be passed from CI -->
<spotless.ratchetFrom/>
<!-- Run tests in Turkish to make sure that they don't depend on locale.
Turkish is a notoriously tricky locale. -->
<surefire.argline>@{argLine} -Duser.language=TR -Duser.country=tr</surefire.argline>
<kotlin.version>2.4.10</kotlin.version>
</properties>
Expand Down Expand Up @@ -196,18 +194,6 @@
<version>${commons-text.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-jdk8</artifactId>
<version>${kotlin.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-test</artifactId>
<version>${kotlin.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
Comment thread
deluxe marked this conversation as resolved.
<build>

Expand All @@ -220,7 +206,7 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven-compiler-plugin.version}</version>
<configuration>
<release>${releaseJavaVersion}</release>
<release>${java.version}</release>
</configuration>
</plugin>
<plugin>
Expand Down Expand Up @@ -282,7 +268,7 @@
<version>[3.9,)</version>
</requireMavenVersion>
<requireJavaVersion>
<version>[${buildJavaVersion},)</version>
<version>[${java.version},)</version>
</requireJavaVersion>
Comment thread
deluxe marked this conversation as resolved.
<requirePluginVersions>
<message>Best practice is to always define Maven plugin versions</message>
Expand Down Expand Up @@ -445,7 +431,7 @@
</execution>
</executions>
</plugin>
<!-- Attaching java doc to comply OSSRH -->
<!-- Attaching Javadoc to comply OSSRH -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
Expand Down Expand Up @@ -532,66 +518,7 @@
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-maven-plugin</artifactId>
<version>${kotlin.version}</version>
<executions>
<execution>
<id>compile</id>
<phase>compile</phase>
<goals>
<goal>compile</goal>
</goals>
<configuration>
<sourceDirs>
<source>src/main/java</source>
<source>target/generated-sources/annotations</source>
</sourceDirs>
</configuration>
</execution>
<execution>
<id>test-compile</id>
<phase>test-compile</phase>
<goals>
<goal>test-compile</goal>
</goals>
<configuration>
<sourceDirs>
<source>src/test/java</source>
<source>target/generated-test-sources/test-annotations</source>
<source>src/test/kotlin</source>
</sourceDirs>
</configuration>
</execution>
</executions>
<configuration>
<jvmTarget>${releaseJavaVersion}</jvmTarget>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<executions>
<execution>
<id>default-compile</id>
<phase>none</phase>
</execution>
<execution>
<id>default-testCompile</id>
<phase>none</phase>
</execution>
<execution>
<id>compile</id>
<phase>compile</phase>
<goals>
<goal>compile</goal>
</goals>
</execution>
<execution>
<id>testCompile</id>
<phase>test-compile</phase>
<goals>
<goal>testCompile</goal>
</goals>
</execution>
</executions>
<extensions>true</extensions>
</plugin>
Comment thread
deluxe marked this conversation as resolved.
</plugins>
</build>
Expand Down