handlers: cutscene viewed-state and world-map entry acknowledgements - #38
Open
Seltraeh wants to merge 1 commit into
Open
handlers: cutscene viewed-state and world-map entry acknowledgements#38Seltraeh wants to merge 1 commit into
Seltraeh wants to merge 1 commit into
Conversation
Adds persistent cutscene viewed-state so the client can skip scenarios the player has already watched. GetScenarioPlayingInfo returns the recorded set and RaidUpScenarioInfo appends to it, both backed by a new user_scenarios table (17072026_CreateUserScenariosTable). The table is structural and never seeded, so a fresh account still sees every cutscene once. Also registers four acknowledgement stubs fired during the Grand Gaia entry sequence — DungeonEventUpdate, UpdatePermitPlaceInfo, UpdateEventInfo and Chronology. Without them the client receives a Close error and retries at roughly 20 requests a second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handlers: cutscene viewed-state and world-map entry acknowledgements
Branch:
split/09-scenarioBase:
devMerge position: 09 of 13
Adds persistent cutscene state plus four keepalive stubs.
What's included
GetScenarioPlayingInfo(VRfsv4e3) returns the recorded set of watched scenarios;RaidUpScenarioInfo(R38qvphm) appends to it. Both backed byuser_scenarios.DungeonEventUpdate,UpdatePermitPlaceInfo,UpdateEventInfo,Chronology.Why the stubs matter
An unregistered handler returns
GmeError{cmd=Close}, which the client retries at roughly 20 requests a second. These stubs exist to stop that spam, not to implement a feature.Safety
user_scenariosis structural and never seeded — a fresh account still sees every cutscene once.Verification
Enter Grand Gaia; confirm no Close-error retry storm in the request log.