fix: AmazonBedrockRetriever was missing some last details - #3842
Merged
Merged
Conversation
Contributor
Author
|
integrations page PR is here: deepset-ai/haystack-integrations#578 |
Contributor
Coverage report (amazon_bedrock)
This PR does not seem to contain any modification to coverable code. |
davidsbatista
marked this pull request as ready for review
August 24, 2026 13:14
davidsbatista
requested review from
anakin87 and
bogdankostic
and removed request for
a team and
bogdankostic
August 24, 2026 13:14
bogdankostic
left a comment
bogdankostic
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Two points from the issue are still missing though:
- changing the name to
AmazonBedrockKnowledgeBaseRetriever - the documentation page under https://docs.haystack.deepset.ai/docs/next/retrievers
Contributor
Author
That was the original name, and @anakin87 suggested changing it to |
Contributor
Hmm, IMO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.