Repository navigation
feat(sharebar): members tab, all links window and app states - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Share Bar settings B: the Members tab, the All links window, app states, keyboard and VoiceOver, running ops and errors. Also the integration left by the earlier sub-goals:
AppRouter.openAllLinks, General's readers (copy and notify toggles), the shortcut status line, one shared mutation queue, the roster feed to the popover, and theshots.shfixes.Spec tasks done
TASK-4b19, 4b20, 4b21, 4b22, 4b23. A DEC records that screens come from in-app hooks and the fake CLI (no desktop input).
Proof
docs/verification/sharebar-settings-b.md; screens, parity and Mobbin notes indocs/verification/share-bar/settings-b.md. 424 swift tests,mac/build.sh 0.0.0,mac/compat-check.sh v0.9.0.Not attempted
A live VoiceOver pass and real Finder, hotkey and drag input (owner rule). Nothing deployed.