Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/implementation-notes/share-bar-popover.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,8 @@ Delta from SPEC-009 for the drop, drag-out, Quick Look and hotkey tasks. Foundat
- `share state` prints no port for a port share, so Quick Look reads it from a name like `localhost:3000`. A `port` key in the row would remove the guess.
- The footer drag hint names the dragged link, as the prototype does; AppKit gives the source no way to learn the destination app's name.
- Not exercised on a live desktop (owner rule): a real Finder drag onto the status item, a real ⌃⌥S press from another app, a real Space on a focused row, a real drag of a row into TextEdit. The reducer, the Carbon registration and the offscreen captures stand in; SG-16 or the owner's own run closes them.

## Popover in settings B

- D24. Loading, CLI missing and CLI too old replace the list body (`AppStateView`); `Working: add (3/6)` replaces the baseline footer for another process's alive op; a failure footer splits `Next:` into a copyable mono line. Scenes for them: `-ShareBarShotsScene loading|cli-missing|cli-old|focus-third|menu-shift-f10|publish-failure` (`PopoverStore.freezeForShots` holds them against the controller's reads).
- D25. Row actions: VoiceOver gets every row-menu item as an action. Focus moves and restores through `RowFocus`.
14 changes: 14 additions & 0 deletions docs/implementation-notes/share-bar-settings.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,17 @@ Delta from SPEC-009 TASK-4b14 to TASK-4b18. The spec rows are not restated. Popo

- Where the 1Password item list comes from: `op item list --format json` through the located `op`, ids and names only. A locked vault shows the `op` sentence in the picker.
- `member rm` takes `--cloud-links keep|delete`; the Remove member sheet carries the choice and `presentRemoveMember` builds the argv; the Members tab (TASK-4b19) calls it.

## Settings B (SPEC-009 TASK-4b19 to TASK-4b23)

- D16. Members logic is `ShareBarCore/Settings/MembersModel.swift` (filters, counts, row, menu from `can[]`, argv); the tab is `MembersPane`, its state `MembersStore`, its verbs `MembersActions`. Needs a look for a member follows the interactions table (paused, left, expired code, a stopped verb, an active machine member offline with links).
- D17. The tab reads `member ls --json` when it opens (once per second at most, since the tab open and the refresh behind it both ask) and after each member action, reusing the keys the action asked, so one action asks once. Esc on the key ask leaves the list unread with Try again.
- D18. Rotate, Renew and Delete record get confirm sheets (`Impact.rotate`, `renew`, `purge`); Send a new code and Rotate end in the code sheet. Renew uses the CLI's 90 day default.
- D19. The All links window shares the popover's `PopoverStore`: a bulk Remove is one `pending` entry (`removeBulk`) with the popover's Undo and clock, one `rm <id>...` in table order. Another member's link is revoked by the same verb.
- D20. App states are `AppState.of(profiles:failure:)`. `cli_below_min` counts only when every set-up tenant reports it.
- D21. General's readers: copy after sharing and the notification sit in `PopoverStore.runAdd`; the three Notify toggles run through `AttentionNotifier` (first read primes, a cleared fact can fire again). `Notifier` posts only from an app bundle.
- D22. Settings and popover verbs now share the app's `MutationQueue` (`StatusItemController.installShell`); the Settings roster feeds `PopoverStore.setMembers`; the shortcut row shows `hotkeyStatus.message`.
- D23. `shots.sh` creates `SHOTS_OUT`, gains `type` and `click-once`; `axdrive click` skips the follow-up press under `AXDRIVE_NO_PRESS`.
- D24. New refusal sheets: `member_busy`, `cli_below_min` and the join codes (`RefusalSheet.knownJoinOrMember`).

Open: a member's last-seen time is absent from `member ls`, so the sub line shows machine and offline only.
11 changes: 6 additions & 5 deletions docs/specs/SPEC-009-multi-member.md

Large diffs are not rendered by default.

26 changes: 26 additions & 0 deletions docs/verification/multi-member.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Verification: multi-member Share Bar

## Share Bar

### VoiceOver and keyboard checklist (TASK-4b22)

No live VoiceOver pass ran: this run was headless and the owner rule (DEC-84) bars input on the desktop. Each line below names the code that VoiceOver and the keyboard read, and the check that holds it. An owner pass with VoiceOver on remains open.

| Item | Where | Check |
|---|---|---|
| Row label is the name plus the meta line, one per `link_state` | `RowModel.accessibilityLabel` | `AppStateTests.testRowLabelsCarryTheNameAndTheMetaLineForEveryLinkState` |
| Row exposes every menu item as an action, plus More actions | `ListBody.swift` `accessibilityActions`, `RowAccessibility.actions` | `testRowsExposeTheMenuItemsAsAccessibilityActions` |
| Arrow Down twice moves by row id; focus survives a reorder | `RowFocus`, `PopoverStore.update` | `testFocusRestoresByIDAfterARefreshThatReordersRows`; scene `focus-third` |
| Shift-F10 and the ContextMenu key open the row menu | `PopoverController.handle(key:)` | scene `menu-shift-f10` |
| Status item label carries the count | `PopoverViewModel.statusItemLabel` | `testTheStatusItemLabelCarriesTheCount` |
| Footer toast is a live region (`updatesFrequently`), the All links toast too | `FooterBar.status`, `AllLinksView.footer` | AX trait in the views |
| Members rows: label is name, sub line, chip or presence, link count; Actions action | `MemberRowModel.accessibilityLabel` | `MembersModelTests` |
| All links rows: label is name, state word, owner, place, expiry, views | `AllLinksRow.accessibilityLabel` | `AllLinksModelTests` |
| Working line is a live region | `ListBody.swift` `footer-working` | AX trait in the view |
| Esc closes every sheet but progress; arrows move Settings tabs | `SettingsStore.escape`, `SettingsRootView` | settings-a checks |

Color is never the only signal: every state word, chip text and the Working line say it in words.

### Screens

Images, argv logs and parity sheets: `docs/verification/share-bar/settings-b/` (see `docs/verification/share-bar/settings-b.md`).
43 changes: 43 additions & 0 deletions docs/verification/share-bar/settings-b.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# Verification: Share Bar settings B (SPEC-009 TASK-4b19 to TASK-4b23)

Nothing deployed. `mac/` plus docs. Proof file for the ship gate: `docs/verification/sharebar-settings-b.md`.

## Capture sets

| Set | Command | Images |
|---|---|---|
| Members, All links, sheets (window capture) | `SHOTS_OUT=docs/verification/share-bar/settings-b mac/Tests/fixtures/settings/run-shots.sh <step>...` | `4b-<label>-<light\|dark>.png`, `argv/` |
| Popover states and errors (offscreen render) | `mac/Tests/fixtures/states/states-shots.sh docs/verification/share-bar/settings-b` | `<scene>-<light\|dark>.png` |
| Parity sheets and samples | `parity/compare.sh` against `parity/render-reference.sh` renders of revision 8 | `parity/` |

Every state comes from a DEBUG hook or the fake CLI. No pointer or key input reached the desktop.

## Screens per task

| Task | Screens |
|---|---|
| 4b19 | `members-all`, `members-needs-look`, `members-removed`, `members-menu-active`, `members-menu-stale`, `members-menu-removed`, `members-invite-sheet`, `members-invite-code`, `members-rotate-confirm`, `members-pause-resume` (argv: pause then resume) |
| 4b20 | `links-all`, `links-needs-look`, `links-expired`, `links-selected`, `links-no-match`, `links-bulk-remove-pending`, `links-bulk-copied`, `links-bulk-removed` (one `rm` with every id) |
| 4b21 | `loading`, `cli-missing`, `cli-old`, `first-run`; the join sheet from first run is `add-join` of settings A |
| 4b22 | `focus-third`, `menu-shift-f10` |
| 4b23 | `publish-failure`, `working-line` |

## Design parity (revision 8, headless Brave render beside the capture)

Sampled in sRGB (`parity/samples.tsv`): surface, primary ink, title ink, header rule, for light and dark. Largest delta 3 steps (primary ink on Members, light: `#1d1d1f` against `#1a1a1d`, the text weight of the capture). Search placeholder: both use the tertiary token. Separator: 9 percent ink in both.

Deliberate deviations:
- Data differs (the fixtures name An, Nam and Linh; the design names An, Bình and Chi); the layout, copy and states match.
- Link ages read `created today` and `created yesterday`: the CLI reports a day, the design shows minutes and hours.
- The search field of All links shows a focus ring on open (the spec asks for focus on open; the design draws none). The ring is the `focus` token.
- The Members window keeps a 440 pt minimum height so the row menu of a last row fits.
- `focus-third` takes three Down presses from the search field (the first enters row 1). The AC wording matches focus that starts on row 1.

## Mobbin comparison

| Screen | References | Read |
|---|---|---|
| Members tab | Base44 "Members and groups" (counted tabs above a bordered table, status chip, row "..." menu); Sprig "Members" (name, role, row menu, toast); Plane "Members" (search beside the primary button) | Same pattern: a bordered table, a search beside one primary action, a quiet row menu. Share Bar keeps the status chip and presence word inside the row, as Base44 does with Pending. |
| Members row menu | Base44 and Sprig row "..." menu | Menu lists only allowed verbs, destructive last; the references hide the rest as well. |
| All links window | Stripe "Lists" (table, counted tabs); Snowflake "Legacy Notebooks" (tabs, checkboxes, action bar that enables on selection); Canva "Manage links" (name and link columns, row menu) | Share Bar matches the tabs, checkboxes and selection bar of Snowflake; it adds Copy per row. |
| First run, CLI states | settings-a notes | Panel with one prominent action, as in the design. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
version
version
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
version
version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
profiles --json
--profile console rm 7f3a21 91fe20 3c8d11
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
profiles --json
--profile console rm 7f3a21 91fe20 3c8d11
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
profiles --json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config ttl
--profile console config storage_default
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
--profile console member ls --json
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config ttl
--profile console config storage_default
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
--profile console member ls --json
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
profiles --json
--profile console member ls --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
--profile console member add chi2 --machine --invite-ttl 7d
--profile console member ls --json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config ttl
--profile console config storage_default
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
profiles --json
--profile console member ls --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
--profile console member add chi2 --machine --invite-ttl 7d
--profile console member ls --json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config ttl
--profile console config storage_default
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
profiles --json
--profile console member ls --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
--profile console member ls --json
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
profiles --json
--profile console member ls --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
--profile console member ls --json
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config ttl
--profile console config storage_default
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
profiles --json
--profile console member ls --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config storage_default
--profile console config ttl
version
--profile console config storage_default
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
profiles --json
--profile console member ls --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
version
version
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
profiles --json
--profile console member ls --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
profiles --json
profiles --json
--profile console config ttl
profiles --json
--profile console config storage_default
--profile console config ttl
version
--profile console config storage_default
--profile console admin-token --cmd pass show cf-admin
--profile console minter-token --cmd pass show cf-minter
profiles --json
--profile console config ttl
--profile console member ls --json
profiles --json
--profile console config storage_default
--profile console config ttl
--profile console config storage_default
Loading
Loading