Repository navigation
Conversation
3 of 8 tasks
Owner
Author
|
Rename title |
echoix
commented
Oct 4, 2026
echoix
changed the title
The verbose and fatal messages were assembled from fragments such as ' larger than or equal to %f hectares...', which translators cannot reorder. Use one complete string for each combination of thresholds.
The reason was appended to a translated string ending in 'Reason: '.
Cover the render status bar, scatterplot title and axis labels, RLi sample area title (previously a runtime string passed to gettext, so never translated), database table tab labels, GCP overwrite question, and two incomplete or trailing-space messages.
Replace messages assembled from translated fragments or passed to gettext as already-built strings with complete format strings, in the temporal framework, wxGUI toolbars, selectors and logs, and several scripts. Also drop trailing spaces from a few messages. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ds column message
echoix
force-pushed
the
i18n-complete-source-strings-python
branch
from
October 4, 2026 15:07
f25496f to
9705e3b
Compare
echoix
commented
Oct 10, 2026
echoix
left a comment
echoix
left a comment
Owner
Author
There was a problem hiding this comment.
Suggestions from a review of this branch: two more temporal messages that are never translated, an edge case in r.reclass.area where the new branches can print "None", and a placeholder-naming nit. The suggested code passes ruff format.
Generated by Claude Code
echoix
commented
Oct 10, 2026
…eConnection Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Applying the review suggestions for the mogrify and transaction mapset errors kept the old fatal() calls unclosed before the new ones, which made core.py fail to compile.
echoix
force-pushed
the
i18n-complete-source-strings-python
branch
from
October 10, 2026 13:38
be2276f to
d265a24
Compare
echoix
commented
Oct 10, 2026
echoix
force-pushed
the
i18n-complete-source-strings-python
branch
from
October 10, 2026 13:46
76a09d2 to
f16b010
Compare
2 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some messages were built from separately translated fragments, or from a runtime string passed to gettext, so translators cannot adapt word order or punctuation. These were flagged by comments on Weblate. This PR replaces them with complete format strings in the Python tools and the wxGUI; the C code is in a separate PR.
r.reclass.area: complete messages, one per combination of thresholds.r.in.wms,v.what.strds,v.rast.stats,r.in.srtm,m.proj: error and status messages are single strings (no trailing-space fragments).core.py,temporal_algebra.py): the mapset error and the wrong-input error were built before being passed to gettext, so they were never translated._("Select sample area 1 of " + str(n)); it now uses the same msgid as the update just above it.tplot: the CSV error message ended in "or " with nothing after it. It now reads "Please change name of output CSV file or enable overwriting." Please check the wording matches the intent.Motivation and context
Translators on Weblate reported that these messages cannot be translated correctly with a different word order.
How has this been tested?
ruff formatandruff checkreport no changes; the modified files compile.Types of changes
functionality to not work as before)
Checklist
pre-defined prefixes
of this project.
AI assistance (Claude) was used to find the affected strings and to draft these changes.